From: "Theodore Ts'o" <tytso@mit.edu>
To: Leah Rumancik <leah.rumancik@gmail.com>
Cc: linux-ext4@vger.kernel.org, dan.carpenter@oracle.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ext4: fix input checking in fs/jbd2/journal.c
Date: Thu, 24 Jun 2021 10:17:05 -0400 [thread overview]
Message-ID: <YNST4d8fCcGjQmzS@mit.edu> (raw)
In-Reply-To: <20210607175558.3343945-1-leah.rumancik@gmail.com>
On Mon, Jun 07, 2021 at 05:55:58PM +0000, Leah Rumancik wrote:
> Update
>
> if (JBD2_JOURNAL_FLUSH_DISCARD & !blk_queue_discard(q))
>
> to use && instead of &. JBD2_JOURNAL_FLUSH_DISCARD is set to 1 so &
> technically works but && could be a bit faster and will maintain
> correctness in the event the value of JBD2_JOURNAL_FLUSH_DISCARD is
> updated.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
Thanks, I've folded this fix into the base commit.
- Ted
prev parent reply other threads:[~2021-06-24 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 17:55 [PATCH] ext4: fix input checking in fs/jbd2/journal.c Leah Rumancik
2021-06-24 14:17 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNST4d8fCcGjQmzS@mit.edu \
--to=tytso@mit.edu \
--cc=dan.carpenter@oracle.com \
--cc=leah.rumancik@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.