From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C614C2B9F4 for ; Fri, 25 Jun 2021 13:42:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11A34617ED for ; Fri, 25 Jun 2021 13:42:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11A34617ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 705166EDE0; Fri, 25 Jun 2021 13:42:21 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 322576EDE0 for ; Fri, 25 Jun 2021 13:42:19 +0000 (UTC) Received: from maud (unknown [IPv6:2600:8800:8c04:8c00::912b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: alyssa) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8641B1F44361; Fri, 25 Jun 2021 14:42:14 +0100 (BST) Date: Fri, 25 Jun 2021 09:42:08 -0400 From: Alyssa Rosenzweig To: Boris Brezillon Subject: Re: [PATCH v3 05/15] drm/panfrost: Expose exception types to userspace Message-ID: References: <20210625133327.2598825-1-boris.brezillon@collabora.com> <20210625133327.2598825-6-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625133327.2598825-6-boris.brezillon@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , dri-devel@lists.freedesktop.org, Steven Price , Rob Herring , Alyssa Rosenzweig , Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" I'm not convinced. Right now most of our UABI is pleasantly GPU-agnostic. With this suddenly there's divergence between Midgard and Bifrost uABI. With that drawback in mind, could you explain the benefit? On Fri, Jun 25, 2021 at 03:33:17PM +0200, Boris Brezillon wrote: > Job headers contain an exception type field which might be read and > converted to a human readable string by tracing tools. Let's expose > the exception type as an enum so we share the same definition. > > v3: > * Add missing values > > Signed-off-by: Boris Brezillon > --- > include/uapi/drm/panfrost_drm.h | 71 +++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h > index ec19db1eead8..899cd6d952d4 100644 > --- a/include/uapi/drm/panfrost_drm.h > +++ b/include/uapi/drm/panfrost_drm.h > @@ -223,6 +223,77 @@ struct drm_panfrost_madvise { > __u32 retained; /* out, whether backing store still exists */ > }; > > +/* The exception types */ > + > +enum drm_panfrost_exception_type { > + DRM_PANFROST_EXCEPTION_OK = 0x00, > + DRM_PANFROST_EXCEPTION_DONE = 0x01, > + DRM_PANFROST_EXCEPTION_INTERRUPTED = 0x02, > + DRM_PANFROST_EXCEPTION_STOPPED = 0x03, > + DRM_PANFROST_EXCEPTION_TERMINATED = 0x04, > + DRM_PANFROST_EXCEPTION_KABOOM = 0x05, > + DRM_PANFROST_EXCEPTION_EUREKA = 0x06, > + DRM_PANFROST_EXCEPTION_ACTIVE = 0x08, > + DRM_PANFROST_EXCEPTION_JOB_CONFIG_FAULT = 0x40, > + DRM_PANFROST_EXCEPTION_JOB_POWER_FAULT = 0x41, > + DRM_PANFROST_EXCEPTION_JOB_READ_FAULT = 0x42, > + DRM_PANFROST_EXCEPTION_JOB_WRITE_FAULT = 0x43, > + DRM_PANFROST_EXCEPTION_JOB_AFFINITY_FAULT = 0x44, > + DRM_PANFROST_EXCEPTION_JOB_BUS_FAULT = 0x48, > + DRM_PANFROST_EXCEPTION_INSTR_INVALID_PC = 0x50, > + DRM_PANFROST_EXCEPTION_INSTR_INVALID_ENC = 0x51, > + DRM_PANFROST_EXCEPTION_INSTR_TYPE_MISMATCH = 0x52, > + DRM_PANFROST_EXCEPTION_INSTR_OPERAND_FAULT = 0x53, > + DRM_PANFROST_EXCEPTION_INSTR_TLS_FAULT = 0x54, > + DRM_PANFROST_EXCEPTION_INSTR_BARRIER_FAULT = 0x55, > + DRM_PANFROST_EXCEPTION_INSTR_ALIGN_FAULT = 0x56, > + DRM_PANFROST_EXCEPTION_DATA_INVALID_FAULT = 0x58, > + DRM_PANFROST_EXCEPTION_TILE_RANGE_FAULT = 0x59, > + DRM_PANFROST_EXCEPTION_ADDR_RANGE_FAULT = 0x5a, > + DRM_PANFROST_EXCEPTION_IMPRECISE_FAULT = 0x5b, > + DRM_PANFROST_EXCEPTION_OOM = 0x60, > + DRM_PANFROST_EXCEPTION_OOM_AFBC = 0x61, > + DRM_PANFROST_EXCEPTION_UNKNOWN = 0x7f, > + DRM_PANFROST_EXCEPTION_DELAYED_BUS_FAULT = 0x80, > + DRM_PANFROST_EXCEPTION_GPU_SHAREABILITY_FAULT = 0x88, > + DRM_PANFROST_EXCEPTION_SYS_SHAREABILITY_FAULT = 0x89, > + DRM_PANFROST_EXCEPTION_GPU_CACHEABILITY_FAULT = 0x8a, > + DRM_PANFROST_EXCEPTION_TRANSLATION_FAULT_0 = 0xc0, > + DRM_PANFROST_EXCEPTION_TRANSLATION_FAULT_1 = 0xc1, > + DRM_PANFROST_EXCEPTION_TRANSLATION_FAULT_2 = 0xc2, > + DRM_PANFROST_EXCEPTION_TRANSLATION_FAULT_3 = 0xc3, > + DRM_PANFROST_EXCEPTION_TRANSLATION_FAULT_4 = 0xc4, > + DRM_PANFROST_EXCEPTION_TRANSLATION_FAULT_IDENTITY = 0xc7, > + DRM_PANFROST_EXCEPTION_PERM_FAULT_0 = 0xc8, > + DRM_PANFROST_EXCEPTION_PERM_FAULT_1 = 0xc9, > + DRM_PANFROST_EXCEPTION_PERM_FAULT_2 = 0xca, > + DRM_PANFROST_EXCEPTION_PERM_FAULT_3 = 0xcb, > + DRM_PANFROST_EXCEPTION_TRANSTAB_BUS_FAULT_0 = 0xd0, > + DRM_PANFROST_EXCEPTION_TRANSTAB_BUS_FAULT_1 = 0xd1, > + DRM_PANFROST_EXCEPTION_TRANSTAB_BUS_FAULT_2 = 0xd2, > + DRM_PANFROST_EXCEPTION_TRANSTAB_BUS_FAULT_3 = 0xd3, > + DRM_PANFROST_EXCEPTION_ACCESS_FLAG_0 = 0xd8, > + DRM_PANFROST_EXCEPTION_ACCESS_FLAG_1 = 0xd9, > + DRM_PANFROST_EXCEPTION_ACCESS_FLAG_2 = 0xda, > + DRM_PANFROST_EXCEPTION_ACCESS_FLAG_3 = 0xdb, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_IN0 = 0xe0, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_IN1 = 0xe1, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_IN2 = 0xe2, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_IN3 = 0xe3, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_OUT0 = 0xe4, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_OUT1 = 0xe5, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_OUT2 = 0xe6, > + DRM_PANFROST_EXCEPTION_ADDR_SIZE_FAULT_OUT3 = 0xe7, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_FAULT_0 = 0xe8, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_FAULT_1 = 0xe9, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_FAULT_2 = 0xea, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_FAULT_3 = 0xeb, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_NONCACHE_0 = 0xec, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_NONCACHE_1 = 0xed, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_NONCACHE_2 = 0xee, > + DRM_PANFROST_EXCEPTION_MEM_ATTR_NONCACHE_3 = 0xef, > +}; > + > #if defined(__cplusplus) > } > #endif > -- > 2.31.1 >