All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Matt Johnston <matt@codeconstruct.com.au>
Cc: linux-i2c@vger.kernel.org, Jeremy Kerr <jk@codeconstruct.com.au>
Subject: Re: [PATCH] i2c: core: export i2c_smbus_pec()
Date: Fri, 25 Jun 2021 17:06:52 +0200	[thread overview]
Message-ID: <YNXxDPIBQx92HbxE@shikoro> (raw)
In-Reply-To: <YLCs5kPBicVLIpCB@kunai>

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

On Fri, May 28, 2021 at 10:42:14AM +0200, Wolfram Sang wrote:
> On Mon, May 17, 2021 at 11:11:38AM +0800, Matt Johnston wrote:
> > I2C slave interface drivers have to calculate the PEC themselves
> > in the i2c slave event handler. This will be used for an in-progress
> > driver for MCTP I2C transport.
> > 
> > Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
> 
> This is fine per se. Yet, there should be a user if we export it. So,
> I suggest to resend it together with the slave driver using it and I
> will ack this then.

Okay, there was another user requesting this feature with a patch. It
also provided kdoc for i2c_smbus_pec. This, together with the simplified
dependencies of two users in flight, made me apply the other patch, so
you can base your work on top of for-next or 5.14 now. I added you with
an acked-by tag to have you credited, too. I hope you are fine with this
approach.

http://patchwork.ozlabs.org/project/linux-i2c/patch/20210519074934.20712-2-quan@os.amperecomputing.com/


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-06-25 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  3:11 [PATCH] i2c: core: export i2c_smbus_pec() Matt Johnston
2021-05-28  8:42 ` Wolfram Sang
2021-06-25 15:06   ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNXxDPIBQx92HbxE@shikoro \
    --to=wsa@kernel.org \
    --cc=jk@codeconstruct.com.au \
    --cc=linux-i2c@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.