From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/tools/relocs: Mark die() with the printf function attr format
Date: Mon, 28 Jun 2021 16:34:53 +0200 [thread overview]
Message-ID: <YNneDYWw4MtQh0WH@kroah.com> (raw)
In-Reply-To: <YNnb6Q4QHtNYC049@zn.tnic>
On Mon, Jun 28, 2021 at 04:25:45PM +0200, Borislav Petkov wrote:
> On Sun, Jun 27, 2021 at 05:01:28PM +0200, Greg Kroah-Hartman wrote:
> > This works for me! It should fix the static checking tool that keeps
> > tripping over this pointless warning :)
> >
> > Want to turn it into a real patch?
>
> How's that?
>
> ---
> From: Borislav Petkov <bp@suse.de>
>
> Mark die() as a function which accepts printf-style arguments so that
> the compiler can typecheck them against the supplied format string.
>
> Use the C99 inttypes.h format specifiers as relocs.c gets built for both
> 32- and 64-bit.
>
> Original version of the patch by Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> arch/x86/tools/relocs.c | 37 ++++++++++++++++++++-----------------
> arch/x86/tools/relocs.h | 1 +
> 2 files changed, 21 insertions(+), 17 deletions(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-06-28 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 11:58 [RESEND PATCH] x86/tools/relocs: add __printf attribute to die() Greg Kroah-Hartman
2021-06-24 12:32 ` Borislav Petkov
2021-06-24 14:44 ` Greg Kroah-Hartman
2021-06-25 16:17 ` H. Peter Anvin
2021-06-25 12:06 ` Greg Kroah-Hartman
2021-06-25 14:12 ` Borislav Petkov
2021-06-25 16:19 ` H. Peter Anvin
2021-06-25 16:53 ` Borislav Petkov
2021-06-25 20:38 ` H. Peter Anvin
2021-06-25 21:07 ` Borislav Petkov
2021-06-27 15:01 ` Greg Kroah-Hartman
2021-06-28 14:25 ` [PATCH] x86/tools/relocs: Mark die() with the printf function attr format Borislav Petkov
2021-06-28 14:34 ` Greg Kroah-Hartman [this message]
2021-08-23 5:12 ` [tip: x86/build] " tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNneDYWw4MtQh0WH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.