From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
mihai.carabas@oracle.com, arnd@arndb.de, pizhenwei@bytedance.com,
pbonzini@redhat.com, joe@perches.com
Subject: Re: [PATCH] misc/pvpanic-pci: Allow automatic loading
Date: Mon, 28 Jun 2021 20:08:30 +0300 [thread overview]
Message-ID: <YNoCDmHglfmN15lf@smile.fi.intel.com> (raw)
In-Reply-To: <5e3f7609-4820-6a8b-306e-553f10ce0f8a@redhat.com>
On Mon, Jun 28, 2021 at 05:44:13PM +0200, Eric Auger wrote:
> On 6/28/21 4:54 PM, Greg KH wrote:
> > On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote:
> >> The pvpanic-pci driver does not auto-load and requires manual
> >> modprobe. Let's include a device database using the
> >> MODULE_DEVICE_TABLE macro.
...
> > Is this something that you need? Or is it created by a tool?
>
> the virtual machine monitor (QEMU) exposes the pvpanic-pci device to the
> guest. On guest side the module exists but currently isn't loaded
> automatically. So the driver fails to be probed and does not its job of
> handling guest panic events. We need a SW actor that loads the module
> and I thought this should be handled that way. If not, please could you
> advise?
At least something like about should have been in the commit message.
Otherwise the selling point is unclear.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-06-28 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 14:44 [PATCH] misc/pvpanic-pci: Allow automatic loading Eric Auger
2021-06-28 14:54 ` Greg KH
2021-06-28 15:44 ` Eric Auger
2021-06-28 17:08 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNoCDmHglfmN15lf@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.