From: Peter Xu <peterx@redhat.com>
To: huangy81@chinatelecom.cn
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Chuan Zheng <zhengchuan@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v10 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation
Date: Mon, 28 Jun 2021 19:05:54 -0400 [thread overview]
Message-ID: <YNpV0q1nEF3NiNSt@t490s> (raw)
In-Reply-To: <e0cc5b347011b1cef06ff95446bf8b3d6a6584b0.1624811188.git.huangy81@chinatelecom.cn>
On Mon, Jun 28, 2021 at 12:27:46AM +0800, huangy81@chinatelecom.cn wrote:
> +static void dirtyrate_global_dirty_log_stop(void)
> +{
> + qemu_mutex_lock_iothread();
One thing I missed: maybe we want to sync dirty before stop, so the value will
be more accurate. Perhaps a call to memory_global_dirty_log_sync() here?
> + memory_global_dirty_log_stop(GLOBAL_DIRTY_DIRTY_RATE);
> + qemu_mutex_unlock_iothread();
> +}
--
Peter Xu
next prev parent reply other threads:[~2021-06-28 23:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 16:27 [PATCH v10 0/6] support dirtyrate at the granualrity of vcpu huangy81
[not found] ` <cover.1624811188.git.huangy81@chinatelecom.cn>
2021-06-27 16:27 ` [PATCH v10 1/6] KVM: introduce dirty_pages and kvm_dirty_ring_enabled huangy81
2021-06-27 16:27 ` [PATCH v10 2/6] memory: make global_dirty_tracking a bitmask huangy81
2021-06-27 16:27 ` [PATCH v10 3/6] migration/dirtyrate: introduce struct and adjust DirtyRateStat huangy81
2021-06-27 16:27 ` [PATCH v10 4/6] migration/dirtyrate: adjust order of registering thread huangy81
2021-06-27 16:27 ` [PATCH v10 5/6] migration/dirtyrate: move init step of calculation to main thread huangy81
2021-06-27 16:27 ` [PATCH v10 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation huangy81
2021-06-28 23:05 ` Peter Xu [this message]
2021-06-29 13:04 ` Hyman
2021-06-29 15:18 ` Peter Xu
2021-06-29 15:58 ` Hyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNpV0q1nEF3NiNSt@t490s \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.