From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB31C11F64 for ; Tue, 29 Jun 2021 00:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5092561CE7 for ; Tue, 29 Jun 2021 00:55:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231741AbhF2A55 (ORCPT ); Mon, 28 Jun 2021 20:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbhF2A55 (ORCPT ); Mon, 28 Jun 2021 20:57:57 -0400 Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA7AEC061574 for ; Mon, 28 Jun 2021 17:55:30 -0700 (PDT) Received: by mail-oo1-xc34.google.com with SMTP id g13-20020a4ac4cd0000b029024c717ed8aeso2134895ooq.13 for ; Mon, 28 Jun 2021 17:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GDhA1ihXWrT4DgsTvJJQ3a7lYOW9rbnfSnG4YreGVeA=; b=oj8e2pcBK60S1TBtvC+t9Py/HxixcDr5zIkEvVVua+LBcfEh3p0ocIUFRdUp0E2Qza fnZbyiuoR6KtpkLTuL/7qnIi/6sx6oSwrCBi5ldGJS1JtdIW29twE5NpBy/+l6w1RhQo 2H3ld3K4i/3r3cCUzIXiBQKYm2OogciGNKcAu/nN/dBkG9ZLzAc49BPK0SOknXYuB8iu mz1VhrGlkpu3pTHMfGvjE9MfrVJ76wDpePIbMhdJBCaLLhXqEx1S2GTvPIlmglrFWnAJ XUfaX6fNDxaXt1FxVdsMvYIiNWWuyrsH/p7kmUEbTqAEq9hz7fqCx+AY7JSt/dBjoJXc NL0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GDhA1ihXWrT4DgsTvJJQ3a7lYOW9rbnfSnG4YreGVeA=; b=X5KTNOy3ncrQg+Gos0OolcSyLdmeqmmFyMD8jI/W/ax5k+/d8bj2a1TV5aTVoXtFRh doivLRrVFz4LQthOd5KvPKTnybTpmznOymiDKUXJXfovojXFRrExATOeHVmM0IX17199 21zvKowD6dMVxB1/Qi2aDOEZILM/nQtP7/bPYhpj0zUFUeFO+1KRK5v0sCN/T5jEwiR7 +OVnsOt4Ed/N8/v0batHRwrM2L8WUqOV0TvHRpOBWs03uTeCVz9bRa4k+bjPbdzlONwp vb5lRboZRZNFogB3hw8mIRRSKvpNO+gZYheRw6VF14ACkVjy3zNDZgMbph7QkolSLec/ R/8A== X-Gm-Message-State: AOAM5316XDSEQridEUOQpbAJLmjkC32/jgP0Py65bqowPl3HcHcvXfGO FYY88tMieZEqYzdNL+wuAZIWEg== X-Google-Smtp-Source: ABdhPJz6ly6okfXaVt6HoXYOoXONv648Lesu9RQtGl+S+aWBxk4UTveKkdgkK3EHC9sVwo5TBEpovA== X-Received: by 2002:a4a:8241:: with SMTP id t1mr1748528oog.13.1624928130174; Mon, 28 Jun 2021 17:55:30 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id j13sm3501831oie.27.2021.06.28.17.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 17:55:29 -0700 (PDT) Date: Mon, 28 Jun 2021 19:55:27 -0500 From: Bjorn Andersson To: abhinavk@codeaurora.org Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm/dp: Make it possible to enable the test pattern Message-ID: References: <20210629002234.1787149-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 28 Jun 19:31 CDT 2021, abhinavk@codeaurora.org wrote: > Hi Bjorn > > On 2021-06-28 17:22, Bjorn Andersson wrote: > > The debugfs interface contains the knobs to make the DisplayPort > > controller output a test pattern, unfortunately there's nothing > > currently that actually enables the defined test pattern. > > > > Fixes: de3ee25473ba ("drm/msm/dp: add debugfs nodes for video pattern > > tests") > > Signed-off-by: Bjorn Andersson > > This is not how this debugfs node works. This is meant to be used while > running > DP compliance video pattern test. > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/tools/msm_dp_compliance.c > > While the compliance test is being run with this msm_dp_compliance app > running, > it will draw the test pattern when it gets the "test_active" from the > driver. > > The test pattern which this app draws is as per the requirements of the > compliance test > as the test equipment will match the CRC of the pattern which is drawn. > > The API dp_panel_tpg_config() which you are trying to call here draws the DP > test pattern > from the DP controller hardware but not the pattern which the compliance > test expects. > So clearly not an oversight, but rather me not understanding how to use the test pattern. You say that I should run msm_dp_compliance while the test is running, so how do I run the test? > Its just a debug API to call when required during bringup/debug purposes. > Yes, I was trying to isolate the DP code from some misconfiguration in the DPU during bringup and with this fix the debugfs interface became useful. Regards, Bjorn > Hence this is not the place to call it as it will end up breaking CTS. > > Thanks > > Abhinav > > > --- > > drivers/gpu/drm/msm/dp/dp_debug.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c > > b/drivers/gpu/drm/msm/dp/dp_debug.c > > index 2f6247e80e9d..82911af44905 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_debug.c > > +++ b/drivers/gpu/drm/msm/dp/dp_debug.c > > @@ -305,6 +305,8 @@ static ssize_t dp_test_active_write(struct file > > *file, > > debug->panel->video_test = true; > > else > > debug->panel->video_test = false; > > + > > + dp_panel_tpg_config(debug->panel, debug->panel->video_test); > > } > > } > > drm_connector_list_iter_end(&conn_iter); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BEEC11F66 for ; Tue, 29 Jun 2021 00:55:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2127361D0C for ; Tue, 29 Jun 2021 00:55:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2127361D0C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 039486E5B6; Tue, 29 Jun 2021 00:55:33 +0000 (UTC) Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CADA6E364 for ; Tue, 29 Jun 2021 00:55:30 +0000 (UTC) Received: by mail-oo1-xc2b.google.com with SMTP id u14-20020a4ae68e0000b029024bf1563f62so5262891oot.3 for ; Mon, 28 Jun 2021 17:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GDhA1ihXWrT4DgsTvJJQ3a7lYOW9rbnfSnG4YreGVeA=; b=oj8e2pcBK60S1TBtvC+t9Py/HxixcDr5zIkEvVVua+LBcfEh3p0ocIUFRdUp0E2Qza fnZbyiuoR6KtpkLTuL/7qnIi/6sx6oSwrCBi5ldGJS1JtdIW29twE5NpBy/+l6w1RhQo 2H3ld3K4i/3r3cCUzIXiBQKYm2OogciGNKcAu/nN/dBkG9ZLzAc49BPK0SOknXYuB8iu mz1VhrGlkpu3pTHMfGvjE9MfrVJ76wDpePIbMhdJBCaLLhXqEx1S2GTvPIlmglrFWnAJ XUfaX6fNDxaXt1FxVdsMvYIiNWWuyrsH/p7kmUEbTqAEq9hz7fqCx+AY7JSt/dBjoJXc NL0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GDhA1ihXWrT4DgsTvJJQ3a7lYOW9rbnfSnG4YreGVeA=; b=Q+ZGAPc5thznaPeM1xBJzj2R6TthDKDZd1zxkpcgk0sByy7fIIKHZjWvt2eBrcdwLN UaY7WTCz71SqeFJDtiX+BgfezML20DOpmnKJNg0tRCMILl99z7SCoslhlZ3nVdb9jYAP UU35C4oXxVFdLdfMfI4te3BMqm1U2tgeKwnAhIXnpADoOTM9o7dTOzfmskHxrdvo3uLv 37ZvCAu9an4/HHFo7zGMZ29o4bCy6SkOCHG6rI6z1K1blj9KkPem9rTt9OrrbUc6bMK4 RVHcsKw50zt2WaF6lbQcCgLhqMBfxiJIBplvAPN18pqKTvixMJqWh9fwyXtmzlGcvDeF /Rww== X-Gm-Message-State: AOAM533FrDyJGIAo/NNcj9yybk8dUa8FlL5eDB5gfOH4HA/sMGKiYskS WIhwhc8LeQNkUHkxRhk+9ekpTw== X-Google-Smtp-Source: ABdhPJz6ly6okfXaVt6HoXYOoXONv648Lesu9RQtGl+S+aWBxk4UTveKkdgkK3EHC9sVwo5TBEpovA== X-Received: by 2002:a4a:8241:: with SMTP id t1mr1748528oog.13.1624928130174; Mon, 28 Jun 2021 17:55:30 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id j13sm3501831oie.27.2021.06.28.17.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 17:55:29 -0700 (PDT) Date: Mon, 28 Jun 2021 19:55:27 -0500 From: Bjorn Andersson To: abhinavk@codeaurora.org Subject: Re: [PATCH] drm/msm/dp: Make it possible to enable the test pattern Message-ID: References: <20210629002234.1787149-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon 28 Jun 19:31 CDT 2021, abhinavk@codeaurora.org wrote: > Hi Bjorn > > On 2021-06-28 17:22, Bjorn Andersson wrote: > > The debugfs interface contains the knobs to make the DisplayPort > > controller output a test pattern, unfortunately there's nothing > > currently that actually enables the defined test pattern. > > > > Fixes: de3ee25473ba ("drm/msm/dp: add debugfs nodes for video pattern > > tests") > > Signed-off-by: Bjorn Andersson > > This is not how this debugfs node works. This is meant to be used while > running > DP compliance video pattern test. > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/tools/msm_dp_compliance.c > > While the compliance test is being run with this msm_dp_compliance app > running, > it will draw the test pattern when it gets the "test_active" from the > driver. > > The test pattern which this app draws is as per the requirements of the > compliance test > as the test equipment will match the CRC of the pattern which is drawn. > > The API dp_panel_tpg_config() which you are trying to call here draws the DP > test pattern > from the DP controller hardware but not the pattern which the compliance > test expects. > So clearly not an oversight, but rather me not understanding how to use the test pattern. You say that I should run msm_dp_compliance while the test is running, so how do I run the test? > Its just a debug API to call when required during bringup/debug purposes. > Yes, I was trying to isolate the DP code from some misconfiguration in the DPU during bringup and with this fix the debugfs interface became useful. Regards, Bjorn > Hence this is not the place to call it as it will end up breaking CTS. > > Thanks > > Abhinav > > > --- > > drivers/gpu/drm/msm/dp/dp_debug.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c > > b/drivers/gpu/drm/msm/dp/dp_debug.c > > index 2f6247e80e9d..82911af44905 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_debug.c > > +++ b/drivers/gpu/drm/msm/dp/dp_debug.c > > @@ -305,6 +305,8 @@ static ssize_t dp_test_active_write(struct file > > *file, > > debug->panel->video_test = true; > > else > > debug->panel->video_test = false; > > + > > + dp_panel_tpg_config(debug->panel, debug->panel->video_test); > > } > > } > > drm_connector_list_iter_end(&conn_iter);