From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06810C11F66 for ; Tue, 29 Jun 2021 14:01:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDB9C61DBC for ; Tue, 29 Jun 2021 14:01:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDB9C61DBC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TbjogeiprlcG+QPOiDcMqVe0y7+uhlEIakju3XxC2ko=; b=qKx43D+n5B43Pn xHAGEnDzSQpRVSo7qf9hWX3PfsgWCbejMRdR4NWS1itA2HnalY0rWun0SbkNwgnvOjMbrXppdkq4m 2FHlTAt+6oEoDhifs/y+O8HVr0N0Nctiwcnec3xD4Fwi46iXz9Yv2PfVHaIJZ2A2QSapMWfzeoDjn NBiGMBydArAkXXZ+5rQoFUzl28OD88tT9GvhgQYuVJ273YIjkbfCZDhtxY7UW8CX/Dyhi+aJeWjwg 3je3tdKSSiEgtRFqlY7Wj00JywTyyOkS6M+LZANw5Hpuo9Wzdz1GpKEtuoWCARWozbtUgSuA0ZKkM q0bY4c9QX8XJ7OoVfg9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyEGd-00BBdM-L6; Tue, 29 Jun 2021 13:59:11 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyEG9-00BBMY-2W for linux-arm-kernel@lists.infradead.org; Tue, 29 Jun 2021 13:58:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GE7y013gv+UJQ2wwu8UtEPjl7ZCtbs5UT/PDFigCAxs=; b=4gilTUTJK1UASaINjjFSWPJ23w WX+1ETjlJyIlT6bFeHKNzSMK/69EPcZWgSK4XQMC0q3OjknIqq3OBz4TM81sumIo78jQV6xzBgDYO hqUfxsMcK/FjmwBvk1Cv7cGObdvr9UfMH+lq+A95S+wrzNOhq/27GYf21uhn9uBzmLo4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lyEFr-00BXyW-Jn; Tue, 29 Jun 2021 15:58:23 +0200 Date: Tue, 29 Jun 2021 15:58:23 +0200 From: Andrew Lunn To: Harini Katakam Cc: robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, steen.hegelund@microchip.com, bjarni.jonasson@microchip.com, ioana.ciornei@nxp.com, likaige@loongson.cn, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com, michal.simek@xilinx.com, radhey.shyam.pandey@xilinx.com Subject: Re: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions Message-ID: References: <20210629094038.18610-1-harini.katakam@xilinx.com> <20210629094038.18610-2-harini.katakam@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210629094038.18610-2-harini.katakam@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210629_065841_143196_A02D5D69 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 29, 2021 at 03:10:36PM +0530, Harini Katakam wrote: > Add RGMII clock delay definitions in mscc-phy-vsc8531 header. > > Signed-off-by: Harini Katakam > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Michal Simek > --- > include/dt-bindings/net/mscc-phy-vsc8531.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/dt-bindings/net/mscc-phy-vsc8531.h b/include/dt-bindings/net/mscc-phy-vsc8531.h > index 9eb2ec2b2ea9..242eb4c7ede9 100644 > --- a/include/dt-bindings/net/mscc-phy-vsc8531.h > +++ b/include/dt-bindings/net/mscc-phy-vsc8531.h > @@ -28,4 +28,13 @@ > #define VSC8531_FORCE_LED_OFF 14 > #define VSC8531_FORCE_LED_ON 15 > > +#define VSC8531_RGMII_CLK_DELAY_0_2_NS 0 > +#define VSC8531_RGMII_CLK_DELAY_0_8_NS 1 > +#define VSC8531_RGMII_CLK_DELAY_1_1_NS 2 > +#define VSC8531_RGMII_CLK_DELAY_1_7_NS 3 > +#define VSC8531_RGMII_CLK_DELAY_2_0_NS 4 > +#define VSC8531_RGMII_CLK_DELAY_2_3_NS 5 > +#define VSC8531_RGMII_CLK_DELAY_2_6_NS 6 > +#define VSC8531_RGMII_CLK_DELAY_3_4_NS 7 Using defines like this is no longer used. Please specify the delay in pS and convert to a register value within the driver. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C66CAC11F6C for ; Tue, 29 Jun 2021 13:58:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA95D61DD1 for ; Tue, 29 Jun 2021 13:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234199AbhF2OBH (ORCPT ); Tue, 29 Jun 2021 10:01:07 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33264 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233329AbhF2OBH (ORCPT ); Tue, 29 Jun 2021 10:01:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GE7y013gv+UJQ2wwu8UtEPjl7ZCtbs5UT/PDFigCAxs=; b=4gilTUTJK1UASaINjjFSWPJ23w WX+1ETjlJyIlT6bFeHKNzSMK/69EPcZWgSK4XQMC0q3OjknIqq3OBz4TM81sumIo78jQV6xzBgDYO hqUfxsMcK/FjmwBvk1Cv7cGObdvr9UfMH+lq+A95S+wrzNOhq/27GYf21uhn9uBzmLo4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lyEFr-00BXyW-Jn; Tue, 29 Jun 2021 15:58:23 +0200 Date: Tue, 29 Jun 2021 15:58:23 +0200 From: Andrew Lunn To: Harini Katakam Cc: robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, steen.hegelund@microchip.com, bjarni.jonasson@microchip.com, ioana.ciornei@nxp.com, likaige@loongson.cn, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com, michal.simek@xilinx.com, radhey.shyam.pandey@xilinx.com Subject: Re: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions Message-ID: References: <20210629094038.18610-1-harini.katakam@xilinx.com> <20210629094038.18610-2-harini.katakam@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210629094038.18610-2-harini.katakam@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 29, 2021 at 03:10:36PM +0530, Harini Katakam wrote: > Add RGMII clock delay definitions in mscc-phy-vsc8531 header. > > Signed-off-by: Harini Katakam > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Michal Simek > --- > include/dt-bindings/net/mscc-phy-vsc8531.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/dt-bindings/net/mscc-phy-vsc8531.h b/include/dt-bindings/net/mscc-phy-vsc8531.h > index 9eb2ec2b2ea9..242eb4c7ede9 100644 > --- a/include/dt-bindings/net/mscc-phy-vsc8531.h > +++ b/include/dt-bindings/net/mscc-phy-vsc8531.h > @@ -28,4 +28,13 @@ > #define VSC8531_FORCE_LED_OFF 14 > #define VSC8531_FORCE_LED_ON 15 > > +#define VSC8531_RGMII_CLK_DELAY_0_2_NS 0 > +#define VSC8531_RGMII_CLK_DELAY_0_8_NS 1 > +#define VSC8531_RGMII_CLK_DELAY_1_1_NS 2 > +#define VSC8531_RGMII_CLK_DELAY_1_7_NS 3 > +#define VSC8531_RGMII_CLK_DELAY_2_0_NS 4 > +#define VSC8531_RGMII_CLK_DELAY_2_3_NS 5 > +#define VSC8531_RGMII_CLK_DELAY_2_6_NS 6 > +#define VSC8531_RGMII_CLK_DELAY_3_4_NS 7 Using defines like this is no longer used. Please specify the delay in pS and convert to a register value within the driver. Andrew