From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BBB4C11F65 for ; Wed, 30 Jun 2021 09:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D75961C9B for ; Wed, 30 Jun 2021 09:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233969AbhF3Jlw (ORCPT ); Wed, 30 Jun 2021 05:41:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:33944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233541AbhF3Jlt (ORCPT ); Wed, 30 Jun 2021 05:41:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F3F0F61C9A; Wed, 30 Jun 2021 09:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1625045961; bh=zr6H4F0/SPank98jRVLiVD3h1/1RuS16gTOp1s5Dwjc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FDCCM52Tgm/jDzr5NIwjk3FBlhz9nyMHCnmjQj3Ujspj0y5NkhNQU+yCcyAOo4sQO DoBfMu8COoQTDM9J1L97TqZG1MqSIeUZ9U9jMo7po3ITLwDU0KI+gkRJD3t04NFarp ZQPqKaRgsxqpHXydmcpCfnILI5bSpWIG9YdgAPtY= Date: Wed, 30 Jun 2021 11:39:19 +0200 From: Greg KH To: kan.liang@linux.intel.com Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, namhyung@kernel.org, jolsa@redhat.com, ak@linux.intel.com, yao.jin@linux.intel.com Subject: Re: [PATCH V3 1/6] perf/x86/intel/uncore: Add Sapphire Rapids server support Message-ID: References: <1624990443-168533-1-git-send-email-kan.liang@linux.intel.com> <1624990443-168533-2-git-send-email-kan.liang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624990443-168533-2-git-send-email-kan.liang@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 29, 2021 at 11:13:58AM -0700, kan.liang@linux.intel.com wrote: > From: Kan Liang > > Intel Sapphire Rapids supports a discovery mechanism, that allows an > uncore driver to discover the different components ("boxes") of the > chip. > > All the generic information of the uncore boxes should be retrieved from > the discovery tables. This has been enabled with the commit edae1f06c2cd > ("perf/x86/intel/uncore: Parse uncore discovery tables"). Add > use_discovery to indicate the case. The uncore driver doesn't need to > hard code the generic information for each uncore box. > > But we still need to enable various functionality that cannot be > directly discovered. This is done here. > - Add a meaningful name for each uncore block. > - Add CHA filter support. > - The layout of the control registers for each uncore block is a little > bit different from the generic one. Set the platform specific format > and ops. Expose the common ops which can be reused. > - Add a fixed counter for IMC Shouldn't this all be individual patches, one per new feature added? There's a lot of stuff happening all at once here, maybe the perf maintainers are more lax about this type of thing than other subsystems... greg k-h