From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/fanotify: Fix running tests in a loop
Date: Thu, 15 Jul 2021 09:08:15 +0200 [thread overview]
Message-ID: <YO/e3wcY8oXyFCO5@pevik> (raw)
In-Reply-To: <20210714180840.160798-1-amir73il@gmail.com>
Hi Amir,
> Both fanotify19 and fanotify18 leaked fds when run in a loop.
> fanotify19 was not checking child process exit status correctly
> which resulted in random failures.
Thanks for a quick fix!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
FYI both fixes prolonged running for about 100% (comparing with runs on master
which don't fail). Of course, that's not a problem at all, it's just interesting
for me how simple closing of file descriptor can be expensive.
Kind regards,
Petr
# time ./fanotify19 -i40
Summary:
passed 360
failed 0
broken 0
skipped 0
warnings 0
real 0m0,871s
user 0m0,028s
sys 0m0,116s
vs.
Summary:
passed 360
failed 0
broken 0
skipped 0
warnings 0
real 0m0,387s
user 0m0,016s
sys 0m0,122s
# time ./fanotify19 -i10
Summary:
passed 160
failed 0
broken 0
skipped 0
warnings 0
real 0m0,436s
user 0m0,032s
sys 0m0,128s
vs.
Summary:
passed 160
failed 0
broken 0
skipped 0
warnings 0
real 0m0,876s
user 0m0,052s
sys 0m0,105s
next prev parent reply other threads:[~2021-07-15 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 18:08 [LTP] [PATCH] syscalls/fanotify: Fix running tests in a loop Amir Goldstein
2021-07-15 7:08 ` Petr Vorel [this message]
2021-07-15 9:05 ` Amir Goldstein
2021-07-15 9:29 ` Petr Vorel
2021-07-15 11:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO/e3wcY8oXyFCO5@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.