From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F707C07E96 for ; Tue, 13 Jul 2021 11:17:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A54661178 for ; Tue, 13 Jul 2021 11:17:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A54661178 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3GQH-0001lk-Cy for qemu-devel@archiver.kernel.org; Tue, 13 Jul 2021 07:17:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3GP7-00010l-2T for qemu-devel@nongnu.org; Tue, 13 Jul 2021 07:16:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3GP5-0008NN-7F for qemu-devel@nongnu.org; Tue, 13 Jul 2021 07:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626175001; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bd7FMSYZ15gPwMLq3IyAmJG4mZW9VNZTqmiihsk/Oug=; b=edsPKFUj0llJFiLD5eGWGXWufcMaxerJ5y/cIh/6VHjf9xB2bdxi7sEtwGN1hIqiY84k+4 +zCVxDY6AFIHdzQBR7sHlt6sh+fwlbkO6IpstcjC6CZG7IvOl6NphFcV2gtYEGTOj0mYoD IiEOwjzas97PeDzZ3eaGGQYvq5jP+24= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-m39OHWFBOiqRhnzfwyzejQ-1; Tue, 13 Jul 2021 07:16:36 -0400 X-MC-Unique: m39OHWFBOiqRhnzfwyzejQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3CFC1082264; Tue, 13 Jul 2021 11:16:34 +0000 (UTC) Received: from redhat.com (ovpn-113-1.ams2.redhat.com [10.36.113.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAAFB5D6AB; Tue, 13 Jul 2021 11:16:29 +0000 (UTC) Date: Tue, 13 Jul 2021 12:16:27 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Subject: Re: [PULL 0/4] OVMF patches for 2021-07-12 Message-ID: References: <20210712145630.2857814-1-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Dov Murik , Laszlo Ersek , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , QEMU Developers , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 13, 2021 at 11:25:21AM +0100, Peter Maydell wrote: > On Mon, 12 Jul 2021 at 16:02, Philippe Mathieu-Daudé wrote: > > > > The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: > > > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210710' into staging (2021-07-12 11:02:39 +0100) > > > > are available in the Git repository at: > > > > https://github.com/philmd/qemu.git tags/fw-edk2-20210712 > > > > for you to fetch changes up to d1e79210457323b225c369fa00e97577e0d0da95: > > > > MAINTAINERS: remove Laszlo Ersek's entries (2021-07-12 16:55:23 +0200) > > > > ---------------------------------------------------------------- > > Patches related to EDK2/OVMF > > > > - MAINTAINERS: remove Laszlo Ersek's entries > > - Introduce X86_FW_OVMF Kconfig symbol > > - pc_system_ovmf_table_find: Assert that flash was parsed, document > > > > ---------------------------------------------------------------- > > So, even though this pullreq doesn't seem to be changing gitlab CI > config, I get a "yaml invalid" failure in the pipeline: > https://gitlab.com/qemu-project/qemu/-/pipelines/335995843 > > "'build-edk2' job needs 'docker-edk2' job but it was not added to the pipeline" > > Any ideas what that's about? The rules for these two jobs are not compatible with the depedency declared between them. The docker-edk2 job is set to exist only when edk2.yml or Dockerfile are changed: docker-edk2: stage: containers rules: # Only run this job when the Dockerfile is modified - changes: - .gitlab-ci.d/edk2.yml - .gitlab-ci.d/edk2/Dockerfile when: always The build-edk2 job is set to exist based on a wide variety of changes build-edk2: stage: build needs: ['docker-edk2'] rules: # Only run this job when ... - changes: # ... roms/edk2/ is modified (submodule updated) - roms/edk2/* when: always - if: '$CI_COMMIT_REF_NAME =~ /^edk2/' # or the branch/tag starts with 'edk2' when: always - if: '$CI_COMMIT_MESSAGE =~ /edk2/i' # or last commit description contains 'EDK2' when: always If those jobs were independant those different sets of conditions would be ok. The build-edk2 job, however, has a 'needs' clause adding a depdancy on 'docker-edk2'. Given this dependancy, in *EVERY* scenario were 'build-edk2' job exists, the 'docker-edk2' job *MUST* also exist. This isn't the case, hence the failed pipeline. This can be fixed by taking the 'rules' from 'build-edk2' and also applying them to 'docker-edk2'. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|