From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m3gAe-00065v-HV for mharc-grub-devel@gnu.org; Wed, 14 Jul 2021 10:47:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3gAb-00065i-70 for grub-devel@gnu.org; Wed, 14 Jul 2021 10:47:31 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:53538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3gAZ-0006bm-FD for grub-devel@gnu.org; Wed, 14 Jul 2021 10:47:28 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 61711202C7; Wed, 14 Jul 2021 14:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626274046; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iGluLCpRKU0p0pLXh+9vyf3rU3cNOIExz/9XsAOwZiQ=; b=eGG0sCVlTqiRYQd/y3N3K5lQX/OQS7sIVgHJyQadvKmZJXaeu7jGkp6vwHbQWOKi86bHdl iZMm+CzahDkFsISkIFrSOfEepneK7ybu6wK4/x4T9ziu8kHqHokeySLYn3CrL4gi6sIqlL HBMfOfxoTgDbJu32TmcZe2+tZmbDkjI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626274046; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iGluLCpRKU0p0pLXh+9vyf3rU3cNOIExz/9XsAOwZiQ=; b=LmKOq+9c+6oZJxbVh7CzFGzRBc7KV1LI8id9+wH+gQO1c74JAhjPYIy2Om6GrXL4gd3wSD Y8ty6kum2KOXG8CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2E2EB13C04; Wed, 14 Jul 2021 14:47:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kkV7Cf747mCefgAAMHmgww (envelope-from ); Wed, 14 Jul 2021 14:47:26 +0000 Date: Wed, 14 Jul 2021 16:47:24 +0200 From: Petr Vorel To: Daniel Kiper , grub-devel@gnu.org, Michael Chang , Mike Gilbert , Jeff Mahoney Subject: Re: [PATCH 1/2] osdep: Introduce major.h and use it Message-ID: Reply-To: Petr Vorel References: <20210708155558.26466-1-pvorel@suse.cz> <20210708155558.26466-2-pvorel@suse.cz> <20210713173658.fc23yio5tqfwkozi@tomti.i.net-space.pl> <20210714125500.b6ncgaldn2rxck2z@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=195.135.220.29; envelope-from=pvorel@suse.cz; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 14:47:31 -0000 Hi Daniel, ... > > > +/* > > > + * Fix for glibc 2.25 is deprecating the namespace pollution of sys/types.h > > > + * injecting major(), minor(), and makedev() into the compilation environment. > > > + * See configure.ac. > > It seems to me "See configure.ac." is not relevant in the GRUB source. > > So, probably it should be replaced with some text from glibc configure.ac. > I didn't know how to link AC_HEADER_MAJOR with include/grub/osdep/major.h. > Because in the future when glibc 2.25 is old enough the header will be removed > and AC_HEADER_MAJOR might be left in configure.ac (name is different from > MAJOR_IN_{MKDEV,SYSMACROS}). But I can note this in commit message instead. But thinking about it twice also note in configure.ac instead (+ commit message) would be good. But that's just a minor detail. Kind regards, Petr > Kind regards, > Petr > > Daniel