From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 4/8] doc: Remind authors and maintainers to run make check
Date: Wed, 14 Jul 2021 12:56:16 +0200 [thread overview]
Message-ID: <YO7C0DgkpaUSf4Nw@pevik> (raw)
In-Reply-To: <20210714071158.15868-5-rpalethorpe@suse.com>
Hi Richie,
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---
> doc/maintainer-patch-review-checklist.txt | 2 +-
> doc/test-writing-guidelines.txt | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
> diff --git a/doc/maintainer-patch-review-checklist.txt b/doc/maintainer-patch-review-checklist.txt
> index f6682b574..970779acc 100644
> --- a/doc/maintainer-patch-review-checklist.txt
> +++ b/doc/maintainer-patch-review-checklist.txt
> @@ -39,7 +39,7 @@ New test should
> * Use new https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#22-writing-a-test-in-c[C API]
> * Test binaries are added into corresponding '.gitignore' files
> * Check coding style with
> - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl[checkpatch.pl]
> + https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/scripts/checkpatch.pl[checkpatch.pl] and `make check`
> (more in https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#131-c-coding-style[C coding style])
+1
"131" would mean section 1.3.1. If you put it into "2.1 C coding style" the link
should be #21-c-coding-style.
Kind regards,
Petr
> * Docparse documentation
> * If a test is a regression test it should include tags
> diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
> index 74e8ad7ee..e3268852a 100644
> --- a/doc/test-writing-guidelines.txt
> +++ b/doc/test-writing-guidelines.txt
> @@ -308,6 +308,7 @@ NOTE: See also
> 3. The runtest entires are in place
> 4. Test binaries are added into corresponding '.gitignore' files
> 5. Patches apply over the latest git
> +6. 'make check' does not emit any warnings
+1
Kind regards,
Petr
next prev parent reply other threads:[~2021-07-14 10:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 7:11 [LTP] [PATCH v2 0/8] Sparse based checker and rule proposal Richard Palethorpe
2021-07-14 7:11 ` [LTP] [PATCH v2 1/8] Add Sparse based checker and TST_RET/ERR check Richard Palethorpe
2021-07-14 10:43 ` Petr Vorel
2021-07-14 11:21 ` Joerg Vehlow
2021-07-14 13:06 ` Richard Palethorpe
2021-07-19 14:51 ` Cyril Hrubis
2021-07-14 7:11 ` [LTP] [PATCH v2 2/8] Add 'make check' to the build system Richard Palethorpe
2021-07-14 10:46 ` Petr Vorel
2021-07-14 7:11 ` [LTP] [PATCH v2 3/8] doc: Add rules and recommendations list Richard Palethorpe
2021-07-14 10:49 ` Petr Vorel
2021-07-14 13:15 ` Richard Palethorpe
2021-07-21 15:43 ` Petr Vorel
2021-07-14 10:54 ` Petr Vorel
2021-07-14 13:26 ` Richard Palethorpe
2021-07-14 14:34 ` Petr Vorel
2021-07-14 7:11 ` [LTP] [PATCH v2 4/8] doc: Remind authors and maintainers to run make check Richard Palethorpe
2021-07-14 10:56 ` Petr Vorel [this message]
2021-07-14 13:34 ` Richard Palethorpe
2021-07-14 14:30 ` Petr Vorel
2021-07-14 7:11 ` [LTP] [PATCH v2 5/8] doc: Document TEST macro and state TST_RET/ERR rule LTP-002 Richard Palethorpe
2021-07-14 11:16 ` Petr Vorel
2021-07-14 13:37 ` Richard Palethorpe
2021-07-14 7:11 ` [LTP] [PATCH v2 6/8] Reference LTP-002 rule in Cocci scripts Richard Palethorpe
2021-07-14 11:18 ` Petr Vorel
2021-07-14 7:11 ` [LTP] [PATCH v2 7/8] API: Move libtsc.h from realtime tests include to tst_tsc.h Richard Palethorpe
2021-07-14 11:21 ` Petr Vorel
2021-07-14 7:11 ` [LTP] [PATCH v2 8/8] API/tst_tsc: Add guards and remove some boilerplate Richard Palethorpe
2021-07-14 11:22 ` Petr Vorel
2021-07-14 11:23 ` [LTP] [PATCH v2 0/8] Sparse based checker and rule proposal Petr Vorel
2021-07-14 13:43 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO7C0DgkpaUSf4Nw@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.