From: Sasha Levin <sashal@kernel.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH AUTOSEL 5.12 62/80] sched/fair: Take thermal pressure into account while estimating energy
Date: Mon, 5 Jul 2021 06:12:43 -0400 [thread overview]
Message-ID: <YOLbGx2d3lMTHF07@sashalap> (raw)
In-Reply-To: <54648043-4944-08f9-8ce8-8413d8037450@arm.com>
On Mon, Jul 05, 2021 at 09:13:59AM +0100, Lukasz Luba wrote:
>Hi Sasha,
>
>+CC Greg
>
>On 7/5/21 12:05 AM, Sasha Levin wrote:
>>From: Lukasz Luba <lukasz.luba@arm.com>
>>
>>[ Upstream commit 489f16459e0008c7a5c4c5af34bd80898aa82c2d ]
>>
>>Energy Aware Scheduling (EAS) needs to be able to predict the frequency
>>requests made by the SchedUtil governor to properly estimate energy used
>>in the future. It has to take into account CPUs utilization and forecast
>>Performance Domain (PD) frequency. There is a corner case when the max
>>allowed frequency might be reduced due to thermal. SchedUtil is aware of
>>that reduced frequency, so it should be taken into account also in EAS
>>estimations.
>>
>>SchedUtil, as a CPUFreq governor, knows the maximum allowed frequency of
>>a CPU, thanks to cpufreq_driver_resolve_freq() and internal clamping
>>to 'policy::max'. SchedUtil is responsible to respect that upper limit
>>while setting the frequency through CPUFreq drivers. This effective
>>frequency is stored internally in 'sugov_policy::next_freq' and EAS has
>>to predict that value.
>>
>>In the existing code the raw value of arch_scale_cpu_capacity() is used
>>for clamping the returned CPU utilization from effective_cpu_util().
>>This patch fixes issue with too big single CPU utilization, by introducing
>>clamping to the allowed CPU capacity. The allowed CPU capacity is a CPU
>>capacity reduced by thermal pressure raw value.
>>
>>Thanks to knowledge about allowed CPU capacity, we don't get too big value
>>for a single CPU utilization, which is then added to the util sum. The
>>util sum is used as a source of information for estimating whole PD energy.
>>To avoid wrong energy estimation in EAS (due to capped frequency), make
>>sure that the calculation of util sum is aware of allowed CPU capacity.
>>
>>This thermal pressure might be visible in scenarios where the CPUs are not
>>heavily loaded, but some other component (like GPU) drastically reduced
>>available power budget and increased the SoC temperature. Thus, we still
>>use EAS for task placement and CPUs are not over-utilized.
>>
>>Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>>Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
>>Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
>>Link: https://lore.kernel.org/r/20210614191128.22735-1-lukasz.luba@arm.com
>>Signed-off-by: Sasha Levin <sashal@kernel.org>
>>---
>> kernel/sched/fair.c | 11 ++++++++---
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>It has been picked up automatically right?
>To make it fully working you need also this patch:
>https://lore.kernel.org/linux-pm/20210614191030.22241-1-lukasz.luba@arm.com/
>
>It makes sure that the thermal pressure signal gets proper
>information also for CPUs which were offline and then wake-up.
>It has a proper fix tagging with commit hash id.
>That patch can be ported to stable: v5.6+
>I can send it to stable list. Please let me know if you need
>any help.
>
>The same applies to patch which I found for v5.13-stable:
>[PATCH AUTOSEL 5.13 65/85] sched/fair: Take thermal pressure into
>account while estimating energy
>https://lore.kernel.org/stable/20210704230420.1488358-65-sashal@kernel.org/T/#u
I took that patch for 5.13-5.10, thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-07-05 10:12 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 23:04 [PATCH AUTOSEL 5.12 01/80] spi: Make of_register_spi_device also set the fwnode Sasha Levin
2021-07-04 23:04 ` [PATCH AUTOSEL 5.12 02/80] Add a reference to ucounts for each cred Sasha Levin
2021-07-04 23:04 ` [PATCH AUTOSEL 5.12 03/80] staging: media: rkvdec: fix pm_runtime_get_sync() usage count Sasha Levin
2021-07-04 23:04 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 04/80] media: i2c: imx334: fix the pm runtime get logic Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 05/80] media: marvel-ccic: fix some issues when getting pm_runtime Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 06/80] media: mdk-mdp: fix pm_runtime_get_sync() usage count Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 07/80] media: s5p: " Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 08/80] media: am437x: " Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 09/80] media: sh_vou: " Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 10/80] media: mtk-vcodec: fix PM runtime get logic Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 11/80] media: s5p-jpeg: fix pm_runtime_get_sync() usage count Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 12/80] media: sunxi: " Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 13/80] media: sti/bdisp: " Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 14/80] media: exynos4-is: " Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 15/80] media: exynos-gsc: " Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 16/80] spi: spi-loopback-test: Fix 'tx_buf' might be 'rx_buf' Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 17/80] spi: spi-topcliff-pch: Fix potential double free in pch_spi_process_messages() Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 18/80] spi: omap-100k: Fix the length judgment problem Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 19/80] regulator: uniphier: Add missing MODULE_DEVICE_TABLE Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 20/80] sched/core: Initialize the idle task with preemption disabled Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [OpenRISC] " Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 21/80] hwrng: exynos - Fix runtime PM imbalance on error Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 22/80] crypto: nx - add missing MODULE_DEVICE_TABLE Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 23/80] regmap-i2c: Set regmap max raw r/w from quirks Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 24/80] media: sti: fix obj-$(config) targets Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 25/80] sched: Make the idle task quack like a per-CPU kthread Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 26/80] media: cpia2: fix memory leak in cpia2_usb_probe Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 27/80] media: cobalt: fix race condition in setting HPD Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 28/80] media: hevc: Fix dependent slice segment flags Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 29/80] media: pvrusb2: fix warning in pvr2_i2c_core_done Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 30/80] media: imx: imx7_mipi_csis: Fix logging of only error event counters Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 31/80] crypto: qat - check return code of qat_hal_rd_rel_reg() Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 32/80] crypto: qat - remove unused macro in FW loader Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 33/80] crypto: qce: skcipher: Fix incorrect sg count for dma transfers Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 34/80] arm64: perf: Convert snprintf to sysfs_emit Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 35/80] sched/fair: Fix ascii art by relpacing tabs Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 36/80] ima: Don't remove security.ima if file must not be appraised Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 37/80] media: i2c: ov2659: Use clk_{prepare_enable,disable_unprepare}() to set xvclk on/off Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 38/80] media: bt878: do not schedule tasklet when it is not setup Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 39/80] media: em28xx: Fix possible memory leak of em28xx struct Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 40/80] media: hantro: Fix .buf_prepare Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 41/80] media: cedrus: " Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 42/80] media: v4l2-core: Avoid the dangling pointer in v4l2_fh_release Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 43/80] media: bt8xx: Fix a missing check bug in bt878_probe Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 44/80] media: st-hva: Fix potential NULL pointer dereferences Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 45/80] crypto: hisilicon/sec - fixup 3des minimum key size declaration Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 46/80] Makefile: fix GDB warning with CONFIG_RELR Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 47/80] media: dvd_usb: memory leak in cinergyt2_fe_attach Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 48/80] memstick: rtsx_usb_ms: fix UAF Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 49/80] mmc: sdhci-sprd: use sdhci_sprd_writew Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 50/80] mmc: via-sdmmc: add a check against NULL pointer dereference Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 51/80] mmc: sdhci-of-aspeed: Turn down a phase correction warning Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 52/80] spi: meson-spicc: fix a wrong goto jump for avoiding memory leak Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 53/80] spi: meson-spicc: fix memory leak in meson_spicc_probe Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 54/80] regulator: mt6315: Fix checking return value of devm_regmap_init_spmi_ext Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 55/80] crypto: shash - avoid comparing pointers to exported functions under CFI Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 56/80] media: dvb_net: avoid speculation from net slot Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 57/80] media: dvbdev: fix error logic at dvb_register_device() Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 58/80] media: siano: fix device register error path Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 59/80] media: imx-csi: Skip first few frames from a BT.656 source Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 60/80] hwmon: (max31790) Report correct current pwm duty cycles Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 61/80] hwmon: (max31790) Fix pwmX_enable attributes Sasha Levin
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 62/80] sched/fair: Take thermal pressure into account while estimating energy Sasha Levin
2021-07-05 8:13 ` Lukasz Luba
2021-07-05 10:12 ` Sasha Levin [this message]
2021-07-04 23:05 ` [PATCH AUTOSEL 5.12 63/80] drivers/perf: fix the missed ida_simple_remove() in ddr_perf_probe() Sasha Levin
2021-07-04 23:05 ` Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 64/80] KVM: arm64: Restore PMU configuration on first run Sasha Levin
2021-07-04 23:06 ` Sasha Levin
2021-07-04 23:06 ` Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 65/80] KVM: PPC: Book3S HV: Fix TLB management on SMT8 POWER9 and POWER10 proces Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 65/80] KVM: PPC: Book3S HV: Fix TLB management on SMT8 POWER9 and POWER10 processors Sasha Levin
2021-07-04 23:06 ` Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 66/80] btrfs: fix error handling in __btrfs_update_delayed_inode Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 67/80] btrfs: abort transaction if we fail to update the delayed inode Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 68/80] btrfs: always abort the transaction if we abort a trans handle Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 69/80] btrfs: sysfs: fix format string for some discard stats Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 70/80] btrfs: scrub: fix subpage repair error caused by hard coded PAGE_SIZE Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 71/80] btrfs: make Private2 lifespan more consistent Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 72/80] btrfs: fix the filemap_range_has_page() call in btrfs_punch_hole_lock_range() Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 73/80] btrfs: don't clear page extent mapped if we're not invalidating the full page Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 74/80] btrfs: disable build on platforms having page size 256K Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 75/80] locking/lockdep: Fix the dep path printing for backwards BFS Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 76/80] lockding/lockdep: Avoid to find wrong lock dep path in check_irq_usage() Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 77/80] KVM: s390: get rid of register asm usage Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 78/80] regulator: mt6358: Fix vdram2 .vsel_mask Sasha Levin
2021-07-04 23:06 ` Sasha Levin
2021-07-04 23:06 ` Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 79/80] regulator: da9052: Ensure enough delay time for .set_voltage_time_sel Sasha Levin
2021-07-04 23:06 ` [PATCH AUTOSEL 5.12 80/80] media: Fix Media Controller API config checks Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOLbGx2d3lMTHF07@sashalap \
--to=sashal@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.