From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A562C07E99 for ; Mon, 5 Jul 2021 19:51:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE8B761426 for ; Mon, 5 Jul 2021 19:51:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE8B761426 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=invisiblethingslab.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.150671.278559 (Exim 4.92) (envelope-from ) id 1m0Ud1-0001jG-QG; Mon, 05 Jul 2021 19:51:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 150671.278559; Mon, 05 Jul 2021 19:51:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Ud1-0001j9-Mj; Mon, 05 Jul 2021 19:51:39 +0000 Received: by outflank-mailman (input) for mailman id 150671; Mon, 05 Jul 2021 19:51:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0Ud0-0001ix-Bx for xen-devel@lists.xenproject.org; Mon, 05 Jul 2021 19:51:38 +0000 Received: from out5-smtp.messagingengine.com (unknown [66.111.4.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9ce90abd-ea61-4516-ac18-d2476dffe446; Mon, 05 Jul 2021 19:51:37 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 90A2F5C00E5; Mon, 5 Jul 2021 15:51:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 05 Jul 2021 15:51:37 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Jul 2021 15:51:35 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ce90abd-ea61-4516-ac18-d2476dffe446 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=GcAJb1 3oZBcAKhzUAGxOSPnGwgvzqoE1IRidewX0hco=; b=u8ir7vI0gZ28dMsA9I3elM gvJkKc7FYqqosmpLrgN1FmxXwwktdFo+4uPeMV7bVAoc8eRvV68Luz2XdR9kmAgu Kf4iUvC6PojzG9PtdBgoeGKJzKF7y3brqU39KKzsPz4phgDrKr9Cjc82zjK7VkOd VwsiA6R8zJNeEUhKqYa7OcDipYSZoHLpk0jtXIamOSQcw1tuaAIv/5NpB+Lv1f9f ROqYn9peZlZdnVTOf3/z0uEVoPAjZP37XEeK/gSQtPITC3E25EHGBdNtAD2cN71R 7vvKFXU2DNasp+d8GJ5rmPAUtGFMT0emedQnyHayIv+ifUuthAa0vkDUpfanJ/Ug == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeejgedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteev ffeigffhkefhgfegfeffhfegveeikeettdfhheevieehieeitddugeefteffnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Date: Mon, 5 Jul 2021 21:51:32 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: Re: [PATCH 2/5] tools/python: fix Python3.4 TypeError in format string Message-ID: References: <20210705191027.15107-1-andrew.cooper3@citrix.com> <20210705191027.15107-3-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Md0eUoqfxzWY0I/5" Content-Disposition: inline In-Reply-To: <20210705191027.15107-3-andrew.cooper3@citrix.com> --Md0eUoqfxzWY0I/5 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 5 Jul 2021 21:51:32 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Andrew Cooper Cc: Xen-devel , Olaf Hering , Juergen Gross , Ian Jackson , Wei Liu Subject: Re: [PATCH 2/5] tools/python: fix Python3.4 TypeError in format string On Mon, Jul 05, 2021 at 08:10:24PM +0100, Andrew Cooper wrote: > From: Olaf Hering >=20 > Using the first element of a tuple for a format specifier fails with > python3.4 as included in SLE12: > b =3D b"string/%x" % (i, ) > TypeError: unsupported operand type(s) for %: 'bytes' and 'tuple' >=20 > It happens to work with python 2.7 and 3.6. > To support older Py3, format as strings and explicitly encode as ASCII. >=20 > Signed-off-by: Olaf Hering > Reviewed-by: Andrew Cooper Acked-by: Marek Marczykowski-G=C3=B3recki > --- > tools/python/scripts/convert-legacy-stream | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tools/python/scripts/convert-legacy-stream b/tools/python/sc= ripts/convert-legacy-stream > index 227e1b5c3fd3..7fe375a66810 100755 > --- a/tools/python/scripts/convert-legacy-stream > +++ b/tools/python/scripts/convert-legacy-stream > @@ -346,9 +346,9 @@ def read_libxl_toolstack(vm, data): > if bytearray(name)[-1] !=3D 0: > raise StreamError("physmap name not NUL terminated") > =20 > - root =3D b"physmap/%x" % (phys, ) > - kv =3D [root + b"/start_addr", b"%x" % (start, ), > - root + b"/size", b"%x" % (size, ), > + root =3D ("physmap/%x" % (phys, )).encode('ascii') > + kv =3D [root + b"/start_addr", ("%x" % (start, )).encode('ascii'= ), > + root + b"/size", ("%x" % (size, )).encode('ascii'), > root + b"/name", name[:-1]] > =20 > for key, val in zip(kv[0::2], kv[1::2]): > --=20 > 2.11.0 >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --Md0eUoqfxzWY0I/5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmDjYsUACgkQ24/THMrX 1yzVhwf9G8Boxg811OmgffjkUk7meSDmzPsGU6pL4l15jUZYyeFPQ4uuhtvmZAOz MmoHUEnEKk1SNIFllEvcz5tHH0Bj5zRhoiD4mvwthiKh4QIWA50KpXm//k4tU/K3 4vn3wktPau9+r49q+73u7uCc1CVm4efEfHPhHPyRsI87657jF/8rH5GoB/Mc+1Kd PCdjVfm0dlPcPPFuGa07Xfw7v+ZGWP8GIdFHwtF/iv8UTzwRJG+inVJiZ1x0SAwp p3aZdvFPNH8yPz/BxZOrsH0E7qmPAYL+6C22RcxXmb5e/ldTTZoMHiVlogDoOoCb FAcxECPDcLwptVM74sReJm8TTSNrmg== =uWS4 -----END PGP SIGNATURE----- --Md0eUoqfxzWY0I/5--