From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org,
Artem Blagodarenko <artem.blagodarenko@hpe.com>
Subject: Re: [PATCH] e2fsck: fix ".." more gracefully if possible
Date: Tue, 6 Jul 2021 16:19:51 -0400 [thread overview]
Message-ID: <YOS655NZ3MnautMX@mit.edu> (raw)
In-Reply-To: <20210531233123.16095-1-adilger@whamcloud.com>
On Mon, May 31, 2021 at 05:31:23PM -0600, Andreas Dilger wrote:
> If the "." entry is corrupted, it will be reset in check_dot().
> It is possible that the ".." entry can be recovered from the
> directory block instead of also resetting it immediately. If
> it appears that there is a valid ".." entry in the block, allow
> that to be used, and let check_dotdot() verify the dirent itself.
>
> When resetting the "." and ".." entries, use EXT2_FT_DIR as the
> file type instead of EXT2_FT_UNKNOWN for the very common case of
> filesystems with the "filetype" feature, to avoid later problems
> that can be easily avoided. This can't always be done, even if
> filesystems without "filetype" are totally obsolete, because many
> old test images do not have this feature enabled.
>
> Fixup affected tests using the new "repair-test" script that
> updates the expect.[12] files from $test.[12].log for the given
> tests and re-runs the test to ensure it now passes.
>
> Signed-off-by: Andreas dilger <adilger@whamcloud.com>
> Reviewed-by: Artem Blagodarenko <artem.blagodarenko@hpe.com>
> Lustre-bug-Id: https://jira.whamcloud.com/browse/LU-14710
> Change-Id: Ia5e579bcf31a9d9ee260d5640de6dbdb60514823
> Reviewed-on: https://review.whamcloud.com/43858
Applied, thanks.
- Ted
prev parent reply other threads:[~2021-07-06 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 23:31 [PATCH] e2fsck: fix ".." more gracefully if possible Andreas Dilger
2021-07-06 20:19 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOS655NZ3MnautMX@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=artem.blagodarenko@hpe.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.