From: "Theodore Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, Dusty Mabe <dustymabe@redhat.com>
Subject: Re: [PATCH] e2fsck: fix last mount/write time when e2fsck is forced
Date: Tue, 6 Jul 2021 16:23:04 -0400 [thread overview]
Message-ID: <YOS7qJ2P2lIwjazY@mit.edu> (raw)
In-Reply-To: <20210614132725.10339-1-lczerner@redhat.com>
On Mon, Jun 14, 2021 at 03:27:25PM +0200, Lukas Czerner wrote:
> With commit c52d930f e2fsck is no longer able to fix bad last
> mount/write time by default because it is conditioned on s_checkinterval
> not being zero, which it is by default.
>
> One place where it matters is when other e2fsprogs tools require to run
> full file system check before a certain operation. If the last mount
> time is for any reason in future, it will not allow it to run even if
> full e2fsck is ran.
>
> Fix it by checking the last mount/write time when the e2fsck is forced,
> except for the case where we know the system clock is broken.
>
> Fixes: c52d930f ("e2fsck: don't check for future superblock times if checkinterval == 0")
> Reported-by: Dusty Mabe <dustymabe@redhat.com>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2021-07-06 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 13:27 [PATCH] e2fsck: fix last mount/write time when e2fsck is forced Lukas Czerner
2021-07-06 20:23 ` Theodore Ts'o [this message]
2021-07-06 23:52 ` Theodore Ts'o
2021-07-07 8:51 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOS7qJ2P2lIwjazY@mit.edu \
--to=tytso@mit.edu \
--cc=dustymabe@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.