From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD50BC07E96 for ; Wed, 7 Jul 2021 02:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A44AE61CB2 for ; Wed, 7 Jul 2021 02:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbhGGCli (ORCPT ); Tue, 6 Jul 2021 22:41:38 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45247 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229894AbhGGCli (ORCPT ); Tue, 6 Jul 2021 22:41:38 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 1672csQq027444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Jul 2021 22:38:55 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 55CCB15C3CC6; Tue, 6 Jul 2021 22:38:54 -0400 (EDT) Date: Tue, 6 Jul 2021 22:38:54 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/6] libext2fs: improve jbd_debug() implementation Message-ID: References: <20210616045334.1655288-1-ebiggers@kernel.org> <20210616045334.1655288-2-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616045334.1655288-2-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jun 15, 2021 at 09:53:29PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Make jbd_debug() do format string checking (but still get compiled away > to nothing) when --enable-jbd-debug isn't specified, similar to > commit d556435156b7 ("jbd2: avoid -Wempty-body warnings") on the kernel > side. This should prevent --enable-jbd-debug from getting broken due to > bad jbd_debug() statements. It also eliminates a -Wunused-variable > warning where a variable was only used in a jbd_debug() statement. > > Also remove an alternative definition of jbd_debug() that was > conditional on CONFIG_JBD_DEBUG && !CONFIG_JBD_DEBUG, so was dead code. > > Signed-off-by: Eric Biggers Thanks, applied. - Ted