From: Peter Xu <peterx@redhat.com>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: linux-rt-users@vger.kernel.org, williams@redhat.com, jkacur@redhat.com
Subject: Re: [PATCH 2/2] oslat: Don't take trace_threshold into account during preheat
Date: Wed, 7 Jul 2021 13:45:01 -0400 [thread overview]
Message-ID: <YOXoHTxdH2kxM95u@t490s> (raw)
In-Reply-To: <20210707084849.304329-2-nsaenzju@redhat.com>
On Wed, Jul 07, 2021 at 10:48:49AM +0200, Nicolas Saenz Julienne wrote:
> The point of preheat is to make sure CPUs are out of idle and running at
> max frequency by the time the real test starts. So it's expected to
> incur into extra latencies we don't really mean to measure. With this in
> mind, it doesn't make sense to take into account the trace threshold
> during that run. So don't do it.
>
> Note that this has been observed in practice. The threshold would be hit
> during preheat but not during the real test.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-07-07 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 8:48 [PATCH 1/2] oslat: Remove redundant include Nicolas Saenz Julienne
2021-07-07 8:48 ` [PATCH 2/2] oslat: Don't take trace_threshold into account during preheat Nicolas Saenz Julienne
2021-07-07 17:45 ` Peter Xu [this message]
2021-07-09 18:09 ` John Kacur
2021-07-09 18:08 ` John Kacur
2021-07-07 17:44 ` [PATCH 1/2] oslat: Remove redundant include Peter Xu
2021-07-09 18:08 ` John Kacur
2021-07-09 18:08 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOXoHTxdH2kxM95u@t490s \
--to=peterx@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=nsaenzju@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.