From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Thu, 8 Jul 2021 13:58:35 +0200 Subject: [LTP] [PATCH] gethostid: Rewrite with newlib and use/test sethostid In-Reply-To: <16e18b1d-93c7-9885-9485-c2d08c17c02d@huawei.com> References: <20210708080720.18997-1-xieziyao@huawei.com> <16e18b1d-93c7-9885-9485-c2d08c17c02d@huawei.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! > > I made some refine and pushed, thanks! > Thanks for your review. Besides, I noticed the CI fails to be compiled > on Apine. The difference appears to be caused by the underlying libc > implementation: glibc and Alpine's musl-libc. > > Is there anything that needs to be modified for this patch? Or simply > ignore it in the CI script. This has to be fixed, the whole point of the CI is to catch build failures on different libc/compiler combinations. Looking at musl the sethostid() is not implemented at all, so I guess that the correct solution here would be adding a configure check for sethostid() and skip the whole test if it's not available. -- Cyril Hrubis chrubis@suse.cz