diff for duplicates of <YOdxLwJx00nQIR87@google.com> diff --git a/a/1.txt b/N1/1.txt index e46618e..0aef578 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -54,7 +54,9 @@ The halt_wait_ns refactor should be a separate patch. > > /* Attribute wait time */ > if (do_sleep) { -> - vc->runner->stat.halt_wait_ns +> + vc->runner->stat.generic.halt_wait_ns +> ktime_to_ns(cur) - ktime_to_ns(start_wait); +> - vc->runner->stat.halt_wait_ns += +> + vc->runner->stat.generic.halt_wait_ns += +> ktime_to_ns(cur) - ktime_to_ns(start_wait); > + kvm_stats_log_hist_update( > + vc->runner->stat.generic.halt_wait_hist, > + LOGHIST_SIZE_LARGE, @@ -62,7 +64,8 @@ The halt_wait_ns refactor should be a separate patch. > /* Attribute failed poll time */ > - if (vc->halt_poll_ns) > + if (vc->halt_poll_ns) { -> vc->runner->stat.generic.halt_poll_fail_ns +> ktime_to_ns(start_wait) - +> vc->runner->stat.generic.halt_poll_fail_ns += +> ktime_to_ns(start_wait) - > ktime_to_ns(start_poll); > + kvm_stats_log_hist_update( > + vc->runner->stat.generic.halt_poll_fail_hist, @@ -73,7 +76,8 @@ The halt_wait_ns refactor should be a separate patch. > /* Attribute successful poll time */ > - if (vc->halt_poll_ns) > + if (vc->halt_poll_ns) { -> vc->runner->stat.generic.halt_poll_success_ns +> ktime_to_ns(cur) - +> vc->runner->stat.generic.halt_poll_success_ns += +> ktime_to_ns(cur) - > ktime_to_ns(start_poll); > + kvm_stats_log_hist_update( > + vc->runner->stat.generic.halt_poll_success_hist, @@ -181,7 +185,8 @@ avoiding passing in the histogram size. > finish_rcuwait(&vcpu->wait); > cur = ktime_get(); > + if (waited) { -> + vcpu->stat.generic.halt_wait_ns +> + ktime_to_ns(cur) - ktime_to_ns(poll_end); +> + vcpu->stat.generic.halt_wait_ns += +> + ktime_to_ns(cur) - ktime_to_ns(poll_end); > + kvm_stats_log_hist_update(vcpu->stat.generic.halt_wait_hist, > + LOGHIST_SIZE_LARGE, > + ktime_to_ns(cur) - ktime_to_ns(poll_end)); diff --git a/a/content_digest b/N1/content_digest index e100bf5..8371f49 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020210706180350.2838127-5-jingzhangos@google.com\0" "From\0David Matlack <dmatlack@google.com>\0" "Subject\0Re: [PATCH v1 4/4] KVM: stats: Add halt polling related histogram stats\0" - "Date\0Thu, 08 Jul 2021 21:42:07 +0000\0" + "Date\0Thu, 8 Jul 2021 21:42:07 +0000\0" "To\0Jing Zhang <jingzhangos@google.com>\0" "Cc\0KVM <kvm@vger.kernel.org>" KVMPPC <kvm-ppc@vger.kernel.org> @@ -70,7 +70,9 @@ "> \n" "> \t/* Attribute wait time */\n" "> \tif (do_sleep) {\n" - "> -\t\tvc->runner->stat.halt_wait_ns +> +\t\tvc->runner->stat.generic.halt_wait_ns +> \t\t\tktime_to_ns(cur) - ktime_to_ns(start_wait);\n" + "> -\t\tvc->runner->stat.halt_wait_ns +=\n" + "> +\t\tvc->runner->stat.generic.halt_wait_ns +=\n" + "> \t\t\tktime_to_ns(cur) - ktime_to_ns(start_wait);\n" "> +\t\tkvm_stats_log_hist_update(\n" "> +\t\t\t\tvc->runner->stat.generic.halt_wait_hist,\n" "> +\t\t\t\tLOGHIST_SIZE_LARGE,\n" @@ -78,7 +80,8 @@ "> \t\t/* Attribute failed poll time */\n" "> -\t\tif (vc->halt_poll_ns)\n" "> +\t\tif (vc->halt_poll_ns) {\n" - "> \t\t\tvc->runner->stat.generic.halt_poll_fail_ns +> \t\t\t\tktime_to_ns(start_wait) -\n" + "> \t\t\tvc->runner->stat.generic.halt_poll_fail_ns +=\n" + "> \t\t\t\tktime_to_ns(start_wait) -\n" "> \t\t\t\tktime_to_ns(start_poll);\n" "> +\t\t\tkvm_stats_log_hist_update(\n" "> +\t\t\t\tvc->runner->stat.generic.halt_poll_fail_hist,\n" @@ -89,7 +92,8 @@ "> \t\t/* Attribute successful poll time */\n" "> -\t\tif (vc->halt_poll_ns)\n" "> +\t\tif (vc->halt_poll_ns) {\n" - "> \t\t\tvc->runner->stat.generic.halt_poll_success_ns +> \t\t\t\tktime_to_ns(cur) -\n" + "> \t\t\tvc->runner->stat.generic.halt_poll_success_ns +=\n" + "> \t\t\t\tktime_to_ns(cur) -\n" "> \t\t\t\tktime_to_ns(start_poll);\n" "> +\t\t\tkvm_stats_log_hist_update(\n" "> +\t\t\t\tvc->runner->stat.generic.halt_poll_success_hist,\n" @@ -197,7 +201,8 @@ "> \tfinish_rcuwait(&vcpu->wait);\n" "> \tcur = ktime_get();\n" "> +\tif (waited) {\n" - "> +\t\tvcpu->stat.generic.halt_wait_ns +> +\t\t\tktime_to_ns(cur) - ktime_to_ns(poll_end);\n" + "> +\t\tvcpu->stat.generic.halt_wait_ns +=\n" + "> +\t\t\tktime_to_ns(cur) - ktime_to_ns(poll_end);\n" "> +\t\tkvm_stats_log_hist_update(vcpu->stat.generic.halt_wait_hist,\n" "> +\t\t\t\tLOGHIST_SIZE_LARGE,\n" "> +\t\t\t\tktime_to_ns(cur) - ktime_to_ns(poll_end));\n" @@ -209,4 +214,4 @@ "> 2.32.0.93.g670b81a890-goog\n" > -2b79c46e34464dbeb3b4c9664cbebe89b8c96c1c103069d6fa05450928f81316 +58b3d19225cf87791ca8f975d7d0673192886b72656d3278d05ef7832e49d01b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.