From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E294CC07E95 for ; Sat, 10 Jul 2021 06:14:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98DFC6135B for ; Sat, 10 Jul 2021 06:14:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98DFC6135B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E11B6EAD6; Sat, 10 Jul 2021 06:14:50 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id B67576EAD6 for ; Sat, 10 Jul 2021 06:14:48 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 23295094-e146-11eb-8d1a-0050568cd888; Sat, 10 Jul 2021 06:14:51 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id D4A73194B04; Sat, 10 Jul 2021 08:14:54 +0200 (CEST) Date: Sat, 10 Jul 2021 08:14:43 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA Message-ID: References: <20210625121045.81711-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625121045.81711-1-paul@crapouillou.net> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding , list@opendingux.net, Christophe Branchereau Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Paul, On Fri, Jun 25, 2021 at 01:10:44PM +0100, Paul Cercueil wrote: > Add binding for the Innolux EJ030NA panel, which is a 320x480 3.0" 4:3 > 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit > interface. > > Signed-off-by: Paul Cercueil > --- > .../display/panel/innolux,ej030na.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml > new file mode 100644 > index 000000000000..cda36c04e85c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/innolux,ej030na.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Innolux EJ030NA 3.0" (320x480 pixels) 24-bit TFT LCD panel > + > +description: | > + The panel must obey the rules for a SPI slave device as specified in > + spi/spi-controller.yaml > + > +maintainers: > + - Paul Cercueil > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: innolux,ej030na > + > + backlight: true > + port: true > + power-supply: true > + reg: true > + reset-gpios: true > + > +required: > + - compatible > + - reg > + - power-supply > + - reset-gpios > + > +unevaluatedProperties: false I had expected: additionalProperties: false With this fixed: Reviewed-by: Sam Ravnborg > + > +examples: > + - | > + #include > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "innolux,ej030na"; > + reg = <0>; > + > + spi-max-frequency = <10000000>; > + > + reset-gpios = <&gpe 4 GPIO_ACTIVE_LOW>; > + power-supply = <&lcd_power>; > + > + backlight = <&backlight>; > + > + port { > + panel_input: endpoint { > + remote-endpoint = <&panel_output>; > + }; > + }; > + }; > + }; > -- > 2.30.2