From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-kernel@vger.kernel.org, Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrea Merello <andrea.merello@iit.it>
Subject: Re: [PATCH v1 1/1] bitmap.h: add const modifier to bitmap_next_[set/clear]_region() argument
Date: Tue, 27 Jul 2021 14:48:42 +0300 [thread overview]
Message-ID: <YP/ymvrd1zV7z6rF@smile.fi.intel.com> (raw)
In-Reply-To: <20210727094441.9815-1-andrea.merello@gmail.com>
On Tue, Jul 27, 2021 at 11:44:41AM +0200, Andrea Merello wrote:
> Those two functions don't modify the bitmap, so their bitmap argument
> should be const. This patch add this.
Constification is always a good thing. No objections from me,
although Yuri is doing something with them in one of his patch series.
Yuri, do you have a public repo / branch that people can base their changes to
bitmap stuff against of?
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Andrea Merello <andrea.merello@iit.it>
> ---
> include/linux/bitmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index a36cfcec4e77..ea4a8f1a2545 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -458,7 +458,7 @@ static inline void bitmap_replace(unsigned long *dst,
> __bitmap_replace(dst, old, new, mask, nbits);
> }
>
> -static inline void bitmap_next_clear_region(unsigned long *bitmap,
> +static inline void bitmap_next_clear_region(const unsigned long *bitmap,
> unsigned int *rs, unsigned int *re,
> unsigned int end)
> {
> @@ -466,7 +466,7 @@ static inline void bitmap_next_clear_region(unsigned long *bitmap,
> *re = find_next_bit(bitmap, end, *rs + 1);
> }
>
> -static inline void bitmap_next_set_region(unsigned long *bitmap,
> +static inline void bitmap_next_set_region(const unsigned long *bitmap,
> unsigned int *rs, unsigned int *re,
> unsigned int end)
> {
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-27 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 9:44 [PATCH v1 1/1] bitmap.h: add const modifier to bitmap_next_[set/clear]_region() argument Andrea Merello
2021-07-27 11:48 ` Andy Shevchenko [this message]
2021-07-27 15:26 ` Yury Norov
2021-07-28 6:39 ` Andrea Merello
2021-07-28 9:18 ` Andy Shevchenko
2021-07-28 13:46 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP/ymvrd1zV7z6rF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrea.merello@gmail.com \
--cc=andrea.merello@iit.it \
--cc=bgolaszewski@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.