From: Greg KH <gregkh@linuxfoundation.org>
To: Hayes Wang <hayeswang@realtek.com>
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
nic_swsd@realtek.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c
Date: Mon, 26 Jul 2021 09:36:52 +0200 [thread overview]
Message-ID: <YP5mFKeJsGezjdve@kroah.com> (raw)
In-Reply-To: <1394712342-15778-373-Taiwan-albertk@realtek.com>
On Mon, Jul 26, 2021 at 12:01:09PM +0800, Hayes Wang wrote:
> Rename r8152.c with r8152_main.c. Move some basic definitions from
> r8152_main.c to r8152_basic.h. Move the relative code of firmware
> from r8152_main.c to r8152_fw.c. Rename the definition of "EFUSE"
> with "USB_EFUSE".
That is a lot of different things all happening in one commit, why?
Please break this up into "one patch per change" and submit it that way.
But the real question is why break this file up in the first place?
What is wrong with the way it is today? What future changes require
this file to be in smaller pieces? If none, why make this? If there
are future changes, then please submit this change when you submit
those, as that would show a real need.
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-26 7:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 8:54 [PATCH u-boot 0/2] eth/r8152: minor corrections Hayes Wang
2021-07-13 9:18 ` [PATCH net-next 1/2] r8152: group the usb ethernet of realtek Hayes Wang
2020-05-22 8:54 ` [PATCH u-boot 1/2] eth/r8152: fix assigning the wrong endpoint Hayes Wang
2021-07-13 9:18 ` [PATCH net-next 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c Hayes Wang
2020-05-22 13:21 ` [PATCH u-boot 1/2] eth/r8152: fix assigning the wrong endpoint Marek Vasut
2020-05-25 3:11 ` Hayes Wang
2020-05-22 8:54 ` [PATCH u-boot 2/2] eth/r8152: fix typo in register name Hayes Wang
2021-07-26 4:01 ` [PATCH net-next RESEND 0/2] r8152: split the source code Hayes Wang
2020-05-22 13:23 ` [PATCH u-boot 2/2] eth/r8152: fix typo in register name Marek Vasut
2020-05-25 7:47 ` [PATCH u-boot v2 0/2] eth/r8152: minor corrections Hayes Wang
2021-07-26 4:01 ` [PATCH net-next RESEND 1/2] r8152: group the usb ethernet of realtek Hayes Wang
2020-05-25 7:47 ` [PATCH u-boot v2 1/2] eth/r8152: fix assigning the wrong endpoint Hayes Wang
2021-07-26 4:01 ` [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c Hayes Wang
2020-05-25 12:03 ` [PATCH u-boot v2 1/2] eth/r8152: fix assigning the wrong endpoint Marek Vasut
2020-05-25 12:52 ` Hayes Wang
2020-05-25 13:00 ` Marek Vasut
2020-05-26 1:59 ` Hayes Wang
2021-07-26 7:36 ` Greg KH [this message]
2021-07-26 8:26 ` [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c Hayes Wang
2021-07-26 8:37 ` Greg KH
2021-07-26 11:09 ` Hayes Wang
2021-07-26 11:14 ` Greg KH
2021-07-26 11:43 ` Hayes Wang
2020-05-25 7:47 ` [PATCH u-boot v2 2/2] eth/r8152: fix typo in register name Hayes Wang
-- strict thread matches above, loose matches on Subject: below --
2021-07-13 9:18 [PATCH net-next 0/2] r8152: split the source code Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP5mFKeJsGezjdve@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.