From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 04/10] block: remove the GENHD_FL_UP check in blkdev_get_no_open
Date: Mon, 26 Jul 2021 18:16:28 +0800 [thread overview]
Message-ID: <YP6LfPENKbOontfT@T590> (raw)
In-Reply-To: <20210724071249.1284585-5-hch@lst.de>
On Sat, Jul 24, 2021 at 09:12:43AM +0200, Christoph Hellwig wrote:
> The GENHD_FL_UP check in blkdev_get_no_open is superflous. The actual
> non-racy check happens later under open_mutex in blkdev_get_by_dev,
> and the inodes are removed from the inode hash early in del_gendisk,
> so it does not provide any useful short cut.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
next prev parent reply other threads:[~2021-07-26 10:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 7:12 fixes and cleanups for block_device refcounting v3 Christoph Hellwig
2021-07-24 7:12 ` [PATCH 01/10] block: delay freeing the gendisk Christoph Hellwig
2021-07-24 7:12 ` [PATCH 02/10] block: assert the locking state in delete_partition Christoph Hellwig
2021-07-24 7:12 ` [PATCH 03/10] block: unhash the block device inodes earlier Christoph Hellwig
2021-07-26 10:15 ` Ming Lei
2021-07-24 7:12 ` [PATCH 04/10] block: remove the GENHD_FL_UP check in blkdev_get_no_open Christoph Hellwig
2021-07-26 10:16 ` Ming Lei [this message]
2021-07-24 7:12 ` [PATCH 05/10] block: allocate bd_meta_info later in add_partitions Christoph Hellwig
2021-07-24 7:12 ` [PATCH 06/10] block: change the refcounting for partitions Christoph Hellwig
2021-07-26 2:20 ` Damien Le Moal
2021-07-26 10:17 ` Ming Lei
2021-07-24 7:12 ` [PATCH 07/10] btrfs: store a block_device in struct btrfs_ordered_extent Christoph Hellwig
2021-07-24 7:12 ` [PATCH 08/10] loop: don't grab a reference to the block device Christoph Hellwig
2021-07-24 7:12 ` [PATCH 09/10] block: remove bdgrab Christoph Hellwig
2021-07-24 7:12 ` [PATCH 10/10] block: remove bdput Christoph Hellwig
2021-07-24 7:22 ` fixes and cleanups for block_device refcounting v3 Christoph Hellwig
2021-07-24 16:06 ` Jens Axboe
2021-07-24 16:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP6LfPENKbOontfT@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.