From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62CBC4338F for ; Tue, 27 Jul 2021 01:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89B2B60F8F for ; Tue, 27 Jul 2021 01:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229575AbhG0BRB (ORCPT ); Mon, 26 Jul 2021 21:17:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46548 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233249AbhG0BRA (ORCPT ); Mon, 26 Jul 2021 21:17:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=HMgJV3uvT/ccXgXUndUBzgjHpSF3q66T70QHV1OP8Po=; b=3MfQ7sVIZ9ABcm1rZUJXDAOPnh Z43SVdviFaDETNTo9/eYjtVOulvrFrt01OgBt7cqN/Ma1vw5kaHKU1KyAE5wgaLR29ztSF1nOSN5a O7FZ3jlhEOeMSB85yl/jHIuPxJDXRWpCjPBn9tAwS6qbv6ZbmlItSMjNPg8aAknen8VI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m8CLJ-00Ex3M-Ej; Tue, 27 Jul 2021 03:57:13 +0200 Date: Tue, 27 Jul 2021 03:57:13 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Heiner Kallweit , Jacek Anaszewski , Pavel Machek , Florian Fainelli , Tony Nguyen , davem@davemloft.net, kuba@kernel.org, Kurt Kanzenbach , netdev@vger.kernel.org, sasha.neftin@intel.com, vitaly.lifshits@intel.com, vinicius.gomes@intel.com, Sebastian Andrzej Siewior , Dvora Fuxbrumer , "linux-leds@vger.kernel.org" Subject: Re: [PATCH net-next 5/5] igc: Export LEDs Message-ID: References: <88d23db8-d2d2-5816-6ba1-3bd80738c398@gmail.com> <3b7ad100-643e-c173-0d43-52e65d41c8c3@gmail.com> <20210721204543.08e79fac@thinkpad> <20210721220716.539f780e@thinkpad> <4d8db4ce-0413-1f41-544d-fe665d3e104c@gmail.com> <6d2697b1-f0f6-aa9f-579c-48a7abb8559d@gmail.com> <20210727020619.2ba78163@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727020619.2ba78163@thinkpad> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org > The last time we discussed this (Andrew, Pavel and I), we've decided > that for ethernet PHY controlled LEDs we want the devicename part > should be something like > phyN or ethphyN or ethernet-phyN > with N a number unique for every PHY (a simple atomically increased > integer for every ethernet PHY). We might want to rethink this. PHYs typically have 2 or 3 LEDs. So we want a way to indicate which LED of a PHY it is. So i suspect we will want something like ethphyN-led0, ethphyN-led1, ethphyN-led2. I would also suggest N starts at 42, in order to make it clear it is a made up arbitrary number, it has no meaning other than it is unique. What we don't want is people thinking ethphy0-led0 has anything to do with eth0. > I confess that I am growing a little frustrated here, because there > seems to be no optimal solution with given constraints and no official > consensus for a suboptimal yet acceptable solution. I do think it is clear that the base name is mostly irrelevant and not going to be used in any meaningful way. You are unlikely to access these LEDs via /sys/class/leds. You are going to go into /sys/class/net/ and then either follow the device symlink, or the phydev symlink and look for LEDs there. And then only the -ledM part of the name might be useful. Since the name is mostly meaningless, we should just decide and move on. Andrew