From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C912FC07E96 for ; Thu, 15 Jul 2021 11:20:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82EE1613BA for ; Thu, 15 Jul 2021 11:20:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82EE1613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A805F6E5A4; Thu, 15 Jul 2021 11:20:56 +0000 (UTC) Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by gabe.freedesktop.org (Postfix) with ESMTPS id F09576E5A4 for ; Thu, 15 Jul 2021 11:20:55 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id u1so7325880wrs.1 for ; Thu, 15 Jul 2021 04:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VujR+RG/xHuDo2Jj/n++B3DGmrisPobQrMRb6HDhkOU=; b=Euo25SnUR8y/xIH4wZ+DcBaGxBPQdJAkAKhJE4pxtSQ99ChleOcLf06Un+9H72r4/W 0Rdp+KzRiHnC4dxDzncSwz3ZK83TxdLTEmqhEJAOonY8qUKU6sTBOIrKn4xg4IkvdHyN RVh1eL77hG8P3t7j6V/AX8csFP68dbqj+Evgcr5Cd3fK3Q9kD+UVv/Iim7S/FilKL0qR QrfpmNiy+8JLGFO5jSw0YUyOJ+a9nQLG/yZWMCz9CC2rzO5SsvKV9s0E8hX4s6DekW0F 16XHqtkeLFg9AR7jRSBS7PZWCfbEHTZBYVghenVLdz0ccgcIm3a5baL5uw21FhZCVHZq nzrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VujR+RG/xHuDo2Jj/n++B3DGmrisPobQrMRb6HDhkOU=; b=QUQI8/Fnx+LKVL4Rg4xWDPW5JpDmVOQ7s4RQJ4He+qkEi4imm/n/nxWXmYVTfNN516 sG9PLKvH0I92sxjg1pGrh6X3IbfWLxv85Ns/43tAvjsQha0kaOf+msLsQZWIe+Bv9wJ7 fbGhHnCL1BcBELpnNmWScweYWZR3zAW4YRUjoGV5mLFDK/KdAyRmz90dqSH2LwVwkSO0 rX/AToxepttsKF1UA3yk0AX+QRVC09uFasReOYOtzESOqXltOasarUJvUwM3IM8FDjFy A2Hy4xYN3BcQ9bdyLzub9tN8HVr+I7unu9DIyKsauOQ8kjviY9lwm3rarLpylUpcl6Lv FVmA== X-Gm-Message-State: AOAM531X9kdXHwPp8kPjSu+73PwXu9Xj5g6BIqTW2u5rHcwmh5b1rAkx sA7reZSEqe4/Msv3xgUYQqWdKg== X-Google-Smtp-Source: ABdhPJyYTHhMv+lyjlzAvNZqFRBCgFbp4UAevLihRGGlZhdmskEj4ptYiSpmCOauw85Ayb65udVA0w== X-Received: by 2002:a05:6000:154c:: with SMTP id 12mr4921083wry.393.1626348054686; Thu, 15 Jul 2021 04:20:54 -0700 (PDT) Received: from google.com ([109.180.115.218]) by smtp.gmail.com with ESMTPSA id x8sm6171255wrt.93.2021.07.15.04.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 04:20:54 -0700 (PDT) Date: Thu, 15 Jul 2021 12:20:52 +0100 From: Lee Jones To: Linus Walleij Subject: Re: [PATCH v3] backlight: ktd253: Stabilize backlight Message-ID: References: <20210604063201.3235245-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , Daniel Thompson , newbyte@disroot.org, Stephan Gerhold , "open list:DRM PANEL DRIVERS" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 13 Jul 2021, Linus Walleij wrote: > On Fri, Jun 4, 2021 at 8:34 AM Linus Walleij wrote: > > > Remove interrupt disablement during backlight setting. It is > > way to dangerous and makes platforms instable by having it > > miss vblank IRQs leading to the graphics derailing. > > > > The code is using ndelay() which is not available on > > platforms such as ARM and will result in 32 * udelay(1) > > which is substantial. > > > > Add some code to detect if an interrupt occurs during the > > tight loop and in that case just redo it from the top. > > > > Fixes: 5317f37e48b9 ("backlight: Add Kinetic KTD253 backlight driver") > > Cc: Stephan Gerhold > > Reported-by: newbyte@disroot.org > > Signed-off-by: Linus Walleij > > Hm it seems this patch did not make it into v5.14-rc1, could it be applied > as a fix for the -rc:s? Ah, it was sent late in the cycle, so I postponed it. > Shall I resend it with Daniel's ACK? Yes please. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog