From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99983C636CA for ; Fri, 16 Jul 2021 17:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4C47613F2 for ; Fri, 16 Jul 2021 17:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230191AbhGPRES (ORCPT ); Fri, 16 Jul 2021 13:04:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbhGPRER (ORCPT ); Fri, 16 Jul 2021 13:04:17 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A935FC06175F for ; Fri, 16 Jul 2021 10:01:22 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id b5-20020a17090a9905b029016fc06f6c5bso7396590pjp.5 for ; Fri, 16 Jul 2021 10:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NmQnhTlbXOfRCbLf9y86Anaxj0U0hlxHDzqR53g42lw=; b=m/uy5N0lDSdUUcEBsyohxPqG1FA3sC7JLvfidHa/D1BAOgIbSJpan54naFe4u/UBc5 HaKgGoIH0AaG36C9c8AdWbAyqN2RW1LfXZLQEMWVPbpgLe4buI07O1XovW2TBeaa1r/j N+Y7ddaWUtRE8P+Fhr2N09VXZk/VlyFqaRkCeJnHhsEKvpsB6jFfJ/tRAUSdOlEBz264 Sn2R1yjvbhCwdKYGKLaZJ6TqmvxdFr5MLRwKpYyEby3wc3APffdwOcqDm+241Ql0polg rAkvTMN5CvmDpuSpqfIFK/OLKDohaDI+an4dPU083cPjPpGyWy3aYwWuatd1PUuXDio2 dSVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NmQnhTlbXOfRCbLf9y86Anaxj0U0hlxHDzqR53g42lw=; b=SZb/flBpyrZgXoU1F7uNQ+5xfhLpV3UVls8yRfu/Q0waDNLUOYfi42fYiHpbsBm8j1 VTzazH5vClond14GPApixvPvukVRpwY7fLGoA+q90CzCvJR8lYO7YzkU4ANtcFwEzB4v ZwDRIpekgs4V0ggPR0VK7X+WnzPDjZm0beS9ZD34TExHbDuK0oyWwnbfUmPGf9nn6Vha YWv0pnNER+06BTNrSirtiIxqt88/xpRgpqny4vTHMYf6309xhb9cfNV4aYXbyMzevV3P 1wYPSuGzXAPr2T2820AmX0Y1k7G9gE71dKwpuyjywYL2ycnK9VdAH7ZaFldRFUp0IOLD SA0w== X-Gm-Message-State: AOAM532mMFGfB6Zwvbt8hjEAwrACVIMfgBgCuJNSC7YZuQ65f3clkCs1 QAUsdfUQwLGlqVUpWQ7uzyrJNVfmNGyVXQ== X-Google-Smtp-Source: ABdhPJwgnKcszg66mAGtsLOzmFzSVInsvHjsiqvW0a+0Z+ynIpjNPXpC70wcb8yyVlFKOqF0xXWQzg== X-Received: by 2002:a17:902:b90a:b029:12b:3338:1870 with SMTP id bf10-20020a170902b90ab029012b33381870mr8530661plb.73.1626454881971; Fri, 16 Jul 2021 10:01:21 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id n32sm10565381pfv.59.2021.07.16.10.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 10:01:21 -0700 (PDT) Date: Fri, 16 Jul 2021 17:01:17 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Maxim Levitsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: nSVM: Rename nested_svm_vmloadsave() to svm_copy_vmloadsave_state() Message-ID: References: <20210716144104.465269-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210716144104.465269-1-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jul 16, 2021, Vitaly Kuznetsov wrote: > diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c > index 3bd09c50c98b..8493592b63b4 100644 > --- a/arch/x86/kvm/svm/nested.c > +++ b/arch/x86/kvm/svm/nested.c > @@ -722,7 +722,7 @@ void svm_copy_vmrun_state(struct vmcb_save_area *from_save, > to_save->cpl = 0; > } > > -void nested_svm_vmloadsave(struct vmcb *from_vmcb, struct vmcb *to_vmcb) > +void svm_copy_vmloadsave_state(struct vmcb *from_vmcb, struct vmcb *to_vmcb) And swap the parameter order for both functions in a follow-up patch? I.e. have the destination first to match memcpy().