All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: lanevdenoche@gmail.com
Cc: linux-rdma@vger.kernel.org, sagi@grimberg.me,
	dledford@redhat.com, jgg@ziepe.ca,
	Chesnokov Gleb <Chesnokov.G@raidix.com>
Subject: Re: [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE
Date: Sun, 18 Jul 2021 11:50:43 +0300	[thread overview]
Message-ID: <YPPrY1MW51aFRSVb@unreal> (raw)
In-Reply-To: <20210714182646.112181-1-Chesnokov.G@raidix.com>

On Wed, Jul 14, 2021 at 09:26:46PM +0300, lanevdenoche@gmail.com wrote:
> Calling isert_setup_id() from isert_np_cma_handler() is wrong
> since at that time the socket address was still bound to the old cma_id
> which will be destroyed via rdma_destroy_id() only after processing
> the RDMA_CM_EVENT_ADDR_CHANGE event.
> 
>  - isert_np_cma_handler() calls isert_setup_id()
> 
>  - isert_setup_id() calls rdma_bind_addr()
> 
>  - rdma_bind_addr() returns -EADDRINUSE
> 
> Move the creation of the cma_id in workqueue context and delete old
> cma_id directly, not through returning the error code to the upper
> level.

Why do you need workqueue for that?

Is it possible to introduce new function isert_np_reinit_id() and call
it directly?

Thanks

  reply	other threads:[~2021-07-18  8:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 18:26 [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE lanevdenoche
2021-07-18  8:50 ` Leon Romanovsky [this message]
     [not found]   ` <9e97e113abb64952a22430462310ca83@raidix.com>
2021-07-19  6:40     ` Leon Romanovsky
2021-07-19 12:13 ` Jason Gunthorpe
2021-07-19 16:07   ` Chesnokov Gleb
2021-07-19 17:09     ` Jason Gunthorpe
2021-07-19 18:27       ` Sagi Grimberg
2021-07-19 18:29     ` Sagi Grimberg
2021-07-19 20:47       ` Chesnokov Gleb
2021-07-22 14:23       ` Jason Gunthorpe
2021-07-22 19:54         ` Sagi Grimberg
2021-07-27 17:37           ` Jason Gunthorpe
2021-08-06 20:14             ` Sagi Grimberg
2021-08-17  8:30               ` Chesnokov Gleb
2021-08-17 21:27                 ` Sagi Grimberg
2021-09-01 11:43                   ` Chesnokov Gleb
2021-09-01 11:56                     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPPrY1MW51aFRSVb@unreal \
    --to=leon@kernel.org \
    --cc=Chesnokov.G@raidix.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=lanevdenoche@gmail.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.