All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: stable@vger.kernel.org, Nikolay Aleksandrov <nikolay@nvidia.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 5.13 1/2] net: bridge: multicast: fix PIM hello router port marking race
Date: Mon, 19 Jul 2021 15:01:06 +0200	[thread overview]
Message-ID: <YPV3kuo2hK0BWeoo@kroah.com> (raw)
In-Reply-To: <20210719125355.317449-1-razor@blackwall.org>

On Mon, Jul 19, 2021 at 03:53:54PM +0300, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@nvidia.com>
> 
> commit 04bef83a3358946bfc98a5ecebd1b0003d83d882 upstream.
> 
> When a PIM hello packet is received on a bridge port with multicast
> snooping enabled, we mark it as a router port automatically, that
> includes adding that port the router port list. The multicast lock
> protects that list, but it is not acquired in the PIM message case
> leading to a race condition, we need to take it to fix the race.
> 
> Cc: stable@vger.kernel.org
> Fixes: 91b02d3d133b ("bridge: mcast: add router port on PIM hello message")
> Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  net/bridge/br_multicast.c | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for the backports, all now queued up.

greg k-h

      parent reply	other threads:[~2021-07-19 13:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 12:53 [PATCH 5.13 1/2] net: bridge: multicast: fix PIM hello router port marking race Nikolay Aleksandrov
2021-07-19 12:53 ` [PATCH 5.13 2/2] net: bridge: multicast: fix MRD advertisement " Nikolay Aleksandrov
2021-07-19 13:01 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPV3kuo2hK0BWeoo@kroah.com \
    --to=greg@kroah.com \
    --cc=davem@davemloft.net \
    --cc=nikolay@nvidia.com \
    --cc=razor@blackwall.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.