From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF73FC07E9B for ; Mon, 19 Jul 2021 10:47:24 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 731DB60200 for ; Mon, 19 Jul 2021 10:47:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 731DB60200 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.158306.291516 (Exim 4.92) (envelope-from ) id 1m5Qnl-00004r-Ns; Mon, 19 Jul 2021 10:47:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 158306.291516; Mon, 19 Jul 2021 10:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Qnl-0008WQ-KB; Mon, 19 Jul 2021 10:47:09 +0000 Received: by outflank-mailman (input) for mailman id 158306; Mon, 19 Jul 2021 10:47:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m5Qnk-0008WK-4J for xen-devel@lists.xenproject.org; Mon, 19 Jul 2021 10:47:08 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1a428b62-a365-417d-afb0-094e33c6195d; Mon, 19 Jul 2021 10:47:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a428b62-a365-417d-afb0-094e33c6195d DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626691626; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nW5Eakjigrup7MIKKykkXAdH5RJYTrC7KTBeqfX1idc=; b=KgqVIjM+IYcVqnuf+64qMM8788cHuI6iMUnO7Nj31glanvrdw1qf53lc +cZaN96en0GIRaGrAMEJ/+Bj6kvE54OfTlYbUIWm70HvfAoL58ZYdKtfS S3URmLFz0hOL/gessl6UvFJn1aGFfLtMJXHyNZpMleLSwg0tHybO1RuhZ I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: Nh3d0PwYnPJ/IoxcbBcl0hsP4P/Grmng47bky05K5cTS9U2jPjRwsqFaS3WxT5vwNA/PTBAJsf UgVeKCMb5vxgd7yrcWF62Wbkjoq2DjLyhbNKH8e7YSEQ8Px0YmatP5/kmiMKq1WMd30M+YNSSD msD6wRVzrLWiGyIlBM+yj1Z9k+Hqg13o/S1l/+LBDVAE14Dk3mh47PJiyrjsE7jnQD3quiM8cP fMUc1kiNCbUC8epW7vH4go/N/bksM7YujlfFIOMirGbDbmi/K3TSeRLyBoxffniJc2R3QZ+vBQ WtNkIhyFYvDtOGvKR4vXeqrs X-SBRS: 5.1 X-MesageID: 48555527 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:+nmE6ajHXfTh7TgTfFR/vHJ3pnBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.84,252,1620705600"; d="scan'208";a="48555527" Date: Mon, 19 Jul 2021 11:47:02 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [XEN PATCH v2] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available Message-ID: References: <20210714161734.256246-1-anthony.perard@citrix.com> <20210716123812.494081-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Jul 19, 2021 at 09:37:06AM +0200, Jan Beulich wrote: > On 16.07.2021 14:38, Anthony PERARD wrote: > > +export HAS_CHECKPOLICY := $(call success,$(CHECKPOLICY) -h 2>&1 | grep -q xen) > > While the setting indeed gets obtained in a Makefile now, ... > > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -235,8 +235,8 @@ config XSM_FLASK_AVC_STATS > > > > config XSM_FLASK_POLICY > > bool "Compile Xen with a built-in FLASK security policy" > > - default y if "$(XEN_HAS_CHECKPOLICY)" = "y" > > - depends on XSM_FLASK > > + default y > > + depends on XSM_FLASK && "$(HAS_CHECKPOLICY)" > > ... it's still used as a Kconfig dependency. This in particular > does not address George's concern about a setting silently getting > turned off behind the back of the person having enabled it (and This patch v2 wasn't meant to address George's concern which didn't exist at the time this v2 was sent... I was trying to address yours. But it seems that "George's concern" is part of your issues with Kconfig too, which I missed when trying to right this v2. Anyway, those two patches are the only way I'm going to try to fix the random build failure in the GitLab CI, I'm not going to try to fix issues with the use of Kconfig for now. In the mean time either v1 or v2 is committed, or will just keep getting random build failure in the GitLab CI. -- Anthony PERARD