From: Greg KH <greg@kroah.com>
To: Davis <davis@mosenkovs.lv>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 4.4] mac80211: fix memory corruption in EAPOL handling
Date: Mon, 19 Jul 2021 14:40:15 +0200 [thread overview]
Message-ID: <YPVyrwvNnTGkZTdm@kroah.com> (raw)
In-Reply-To: <CAHQn7p+dA3-FS+DGPqCvXJGtTZfWqg9hy1GUbtWFwtQFvKcnfg@mail.gmail.com>
On Fri, Jul 16, 2021 at 01:02:06AM +0300, Davis wrote:
> On 2021-07-15 at 15:36 Greg KH (<greg@kroah.com>) wrote:
> >
> > On Sat, Jul 10, 2021 at 09:37:10PM +0300, Davis Mosenkovs wrote:
> > > Commit e3d4030498c3 ("mac80211: do not accept/forward invalid EAPOL
> > > frames") uses skb_mac_header() before eth_type_trans() is called
> > > leading to incorrect pointer, the pointer gets written to. This issue
> > > has appeared during backporting to 4.4, 4.9 and 4.14.
> >
> > So this is also needed in 4.9 and 4.14, right? If so, now queued up
> > everywhere. If not, please let me know so I can drop it from the other
> > trees.
> >
> > thanks,
> >
> > greg k-h
>
> Thank you! Yes - this is needed in 4.4, 4.9 and 4.14.
> Only line offsets and commit messages (they contain references to
> backport commits introducing the issue) differ between kernel versions
> and I see the patches are queued with correct line offsets.
> Patches for 4.9
> (https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.9/mac80211-fix-memory-corruption-in-eapol-handling.patch)
> and 4.14 (https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14/mac80211-fix-memory-corruption-in-eapol-handling.patch)
> still contain 4.4 in the cc line in sign-off section. Also these
> patches contain reference to commit e3d4030498c3 that is from 4.4
> branch. Is this OK?
It's fine :)
next prev parent reply other threads:[~2021-07-19 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 18:37 [PATCH 4.4] mac80211: fix memory corruption in EAPOL handling Davis Mosenkovs
2021-07-15 11:55 ` Greg KH
2021-07-15 22:02 ` Davis
2021-07-19 12:40 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-07 21:38 Davis Mosenkovs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPVyrwvNnTGkZTdm@kroah.com \
--to=greg@kroah.com \
--cc=davis@mosenkovs.lv \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.