All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Xu Liang <lxu@maxlinear.com>
Cc: hkallweit1@gmail.com, netdev@vger.kernel.org,
	davem@davemloft.net, kuba@kernel.org,
	vee.khee.wong@linux.intel.com, linux@armlinux.org.uk,
	hmehrtens@maxlinear.com, tmohren@maxlinear.com,
	mohammad.athari.ismail@intel.com
Subject: Re: [PATCH v6 2/2] net: phy: add Maxlinear GPY115/21x/24x driver
Date: Mon, 19 Jul 2021 22:48:00 +0200	[thread overview]
Message-ID: <YPXlAFZCU3T+ua93@lunn.ch> (raw)
In-Reply-To: <20210719053212.11244-2-lxu@maxlinear.com>

> +/* PHY ID */
> +#define PHY_ID_GPYx15B_MASK	0xFFFFFFFC
> +#define PHY_ID_GPY21xB_MASK	0xFFFFFFF9

That is an odd mask. Is that really correct?

     Andrew

  parent reply	other threads:[~2021-07-19 23:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  5:32 [PATCH v6 1/2] net: phy: add API to read 802.3-c45 IDs Xu Liang
2021-07-19  5:32 ` [PATCH v6 2/2] net: phy: add Maxlinear GPY115/21x/24x driver Xu Liang
2021-07-19 18:30   ` Hauke Mehrtens
2021-07-19 20:48   ` Andrew Lunn [this message]
2021-07-20  3:35     ` Liang Xu
2021-07-20 13:02       ` Andrew Lunn
2021-07-20 13:18         ` Liang Xu
2021-07-20  0:58   ` Wong Vee Khee
2021-07-20  1:03   ` Wong Vee Khee
2021-07-20 14:11   ` Andrew Lunn
2021-07-19 18:30 ` [PATCH v6 1/2] net: phy: add API to read 802.3-c45 IDs Hauke Mehrtens
2021-07-19 20:40 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPXlAFZCU3T+ua93@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=hmehrtens@maxlinear.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lxu@maxlinear.com \
    --cc=mohammad.athari.ismail@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=tmohren@maxlinear.com \
    --cc=vee.khee.wong@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.