From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE13C07E95 for ; Tue, 20 Jul 2021 10:09:31 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 824FF6113A for ; Tue, 20 Jul 2021 10:09:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 824FF6113A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 020C54B0DA; Tue, 20 Jul 2021 06:09:30 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XtTaXUT2RCDU; Tue, 20 Jul 2021 06:09:29 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 17D554B0D4; Tue, 20 Jul 2021 06:09:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AD2194B0CA for ; Tue, 20 Jul 2021 06:09:27 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VRUIKJDYoP4S for ; Tue, 20 Jul 2021 06:09:26 -0400 (EDT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id B1C544A195 for ; Tue, 20 Jul 2021 06:09:26 -0400 (EDT) Received: by mail-wr1-f47.google.com with SMTP id d2so25426268wrn.0 for ; Tue, 20 Jul 2021 03:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0j3bPtwVUVm/jZDBUJXolF4U+AmslpUbr8sCL6VPfoA=; b=HAyimdTxgae0VX9e5mbMhkKbnj16MrHWbI0i37pITjBmQQJ4VRXmvUpgvzO9ymMIKg mjrgM+dSiSax+84SIS0Okxr3ALUy2Ehb+jDqtr2dpRRcd9ugaeJaePM84jSgNnWfo7b6 owAA6Yabf9pZ2CECadWlx2Vf/UcEBe3Ru/Hg8eXnI3Od9skjqLcVzLQYwMKdHLP1FjTf UXYVjUdCfgJtyqHqmkXXSPNvKzWc7/4OhrDx4gVDizRY6QqTXT5ADTSEwm8EW6X4NsiK KfeXgor2I58mOMbFMQYxJ6eRaDl5r+ueK7+ScH5nlJkkcOYGasQrSdjuHKcsvRFOpkbH csUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0j3bPtwVUVm/jZDBUJXolF4U+AmslpUbr8sCL6VPfoA=; b=nQzpwWby7J0wWt/TB0Q3vfOXN9EWyY5duuAw2QDde+0FpYOMmmNkbu6dzj4TNff9xR iEr7UTWMS87z4//uviOccrR9oQNzhwWTTmypc0nHqE74UZlfEeD1ECaVsQBxxBTzftp9 DhTNUBKp07FrOTzg1rmoM5IiYU0wQTwT2OWOCKeRGtPlprmcdSahhbr45Dy0C0Vb+Swt 7sUki/O7FeREJubyAmcWXPNXxuJY5VLjUzTYAa3wtDLFx1kelpvKz3CrJdKrNi5eKyZa 1NwmyJZMit4fCUiZgdWwXGtafSb9zwnkE0TtxFdpowhm3NYPnDrR9AjdQTxa2F0J4td1 oShQ== X-Gm-Message-State: AOAM532iS4OWT7n8VCOeoEXqcruY0GTPSVpB1ChGzzATz2d9uQye0FIg A+2nbeBy7RLrjLa9R1mISywc4w== X-Google-Smtp-Source: ABdhPJw9FCFTdkiAN4LxfJoUs++5xlLWx8lVhaIJEWeX7hAEofC+sahFp6Ki2Mrs5oqdp3xuqh93zw== X-Received: by 2002:adf:a2c3:: with SMTP id t3mr33970462wra.223.1626775765602; Tue, 20 Jul 2021 03:09:25 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:83e0:11ac:c870:2b97]) by smtp.gmail.com with ESMTPSA id m15sm19470088wmc.20.2021.07.20.03.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 03:09:25 -0700 (PDT) Date: Tue, 20 Jul 2021 11:09:21 +0100 From: Quentin Perret To: Marc Zyngier Subject: Re: [PATCH 03/16] KVM: arm64: Turn kvm_pgtable_stage2_set_owner into kvm_pgtable_stage2_annotate Message-ID: References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-4-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210715163159.1480168-4-maz@kernel.org> Cc: kernel-team@android.com, kvm@vger.kernel.org, Srivatsa Vaddagiri , linux-kernel@vger.kernel.org, Shanker R Donthineni , will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thursday 15 Jul 2021 at 17:31:46 (+0100), Marc Zyngier wrote: > @@ -815,7 +807,7 @@ int kvm_pgtable_stage2_set_owner(struct kvm_pgtable *pgt, u64 addr, u64 size, > .arg = &map_data, > }; > > - if (owner_id > KVM_MAX_OWNER_ID) > + if (!annotation || (annotation & PTE_VALID)) > return -EINVAL; Why do you consider annotation==0 invalid? The assumption so far has been that the owner_id for the host is 0, so annotating a range with 0s should be a valid operation -- this will be required when e.g. transferring ownership of a page back to the host. > > ret = kvm_pgtable_walk(pgt, addr, size, &walker); > -- > 2.30.2 > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DA1C07E95 for ; Tue, 20 Jul 2021 10:11:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF34B610C7 for ; Tue, 20 Jul 2021 10:11:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF34B610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Dd2Mj1K7P27Hh7ThXLW0Isd3eXXW8gw/e80V+BQPfc=; b=Lc+jfhyZfhhzSi 7Vcn9Bhfl6OFixc+JzaqCxPVOpEbAyaQZk6PCaEU6i0ujc5fd49QTuzrFyZ31Yza2VQ55xrNke9ii 87I14jK76SaFMpWfh2en4o7Xbnp6qQ6lVpLanfN6q11jvJD8ARQFdStObtG7NRIZKhuBlMUW7Tsx2 YSsdD0NF/3bZketzIMeB0+vlG8ofk+nRiM4eV5qRrOlRwQ/301csl/0Cx/nskVquOtv6jbgluqyIm ihNGwcqePtA76ucnHNgIUc7+1ZiR4UiSf56pvLNmc+K5hOqTQyIrlmINMVJORn4S6cJgB3aIjqsdV ziWreLgjasFA/ZPIcBtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5mgt-00CTXi-Qd; Tue, 20 Jul 2021 10:09:32 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5mgp-00CTX8-Ku for linux-arm-kernel@lists.infradead.org; Tue, 20 Jul 2021 10:09:28 +0000 Received: by mail-wr1-x433.google.com with SMTP id i94so25367507wri.4 for ; Tue, 20 Jul 2021 03:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0j3bPtwVUVm/jZDBUJXolF4U+AmslpUbr8sCL6VPfoA=; b=HAyimdTxgae0VX9e5mbMhkKbnj16MrHWbI0i37pITjBmQQJ4VRXmvUpgvzO9ymMIKg mjrgM+dSiSax+84SIS0Okxr3ALUy2Ehb+jDqtr2dpRRcd9ugaeJaePM84jSgNnWfo7b6 owAA6Yabf9pZ2CECadWlx2Vf/UcEBe3Ru/Hg8eXnI3Od9skjqLcVzLQYwMKdHLP1FjTf UXYVjUdCfgJtyqHqmkXXSPNvKzWc7/4OhrDx4gVDizRY6QqTXT5ADTSEwm8EW6X4NsiK KfeXgor2I58mOMbFMQYxJ6eRaDl5r+ueK7+ScH5nlJkkcOYGasQrSdjuHKcsvRFOpkbH csUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0j3bPtwVUVm/jZDBUJXolF4U+AmslpUbr8sCL6VPfoA=; b=mw3JXUgP3n+zmX0vKk7j+AQRVPggE9ebrNSKqY8nL5tEakefOvhe8cqR0yrXh9koap Y0TLvV0DKVHsyrqV5rYecZ2psnUwJHK9VQAxKVpBY4Bwec2EUEFBeRy1loHH9oxj0crC 5qfayQ04v6AtMYa9OXJYQi91nBgT9mjQtVS1aheC6CiH7nBsTBgZU2Zq8re8TiyII4S9 WWui95RQDi9dQDA9zitumm60R0X4yIwiHoSj95yCeY6HIYBWbo+Oym/+7szGX2qo4WI0 +PGVMr6hAB/nOM4m/lE/chdZdqO9/9W6fdDXlGSeeQxEaSsuFSBcNgiNQLQJ7+CwzhLE VLfg== X-Gm-Message-State: AOAM531+tEoKWGHF/BVKsNhhfd8+A+kQFrVDCZgVNd5J5dJs4e8/mgto d1fyFRqtzZdmrcXbPFe8QYz0/g== X-Google-Smtp-Source: ABdhPJw9FCFTdkiAN4LxfJoUs++5xlLWx8lVhaIJEWeX7hAEofC+sahFp6Ki2Mrs5oqdp3xuqh93zw== X-Received: by 2002:adf:a2c3:: with SMTP id t3mr33970462wra.223.1626775765602; Tue, 20 Jul 2021 03:09:25 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:83e0:11ac:c870:2b97]) by smtp.gmail.com with ESMTPSA id m15sm19470088wmc.20.2021.07.20.03.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 03:09:25 -0700 (PDT) Date: Tue, 20 Jul 2021 11:09:21 +0100 From: Quentin Perret To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, will@kernel.org, dbrazdil@google.com, Srivatsa Vaddagiri , Shanker R Donthineni , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 03/16] KVM: arm64: Turn kvm_pgtable_stage2_set_owner into kvm_pgtable_stage2_annotate Message-ID: References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-4-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210715163159.1480168-4-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210720_030927_767701_2DBAA121 X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 15 Jul 2021 at 17:31:46 (+0100), Marc Zyngier wrote: > @@ -815,7 +807,7 @@ int kvm_pgtable_stage2_set_owner(struct kvm_pgtable *pgt, u64 addr, u64 size, > .arg = &map_data, > }; > > - if (owner_id > KVM_MAX_OWNER_ID) > + if (!annotation || (annotation & PTE_VALID)) > return -EINVAL; Why do you consider annotation==0 invalid? The assumption so far has been that the owner_id for the host is 0, so annotating a range with 0s should be a valid operation -- this will be required when e.g. transferring ownership of a page back to the host. > > ret = kvm_pgtable_walk(pgt, addr, size, &walker); > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7070BC07E9B for ; Tue, 20 Jul 2021 10:09:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B54761001 for ; Tue, 20 Jul 2021 10:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235802AbhGTJ2w (ORCPT ); Tue, 20 Jul 2021 05:28:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233914AbhGTJ2t (ORCPT ); Tue, 20 Jul 2021 05:28:49 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15B58C061574 for ; Tue, 20 Jul 2021 03:09:27 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id f17so25379056wrt.6 for ; Tue, 20 Jul 2021 03:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0j3bPtwVUVm/jZDBUJXolF4U+AmslpUbr8sCL6VPfoA=; b=HAyimdTxgae0VX9e5mbMhkKbnj16MrHWbI0i37pITjBmQQJ4VRXmvUpgvzO9ymMIKg mjrgM+dSiSax+84SIS0Okxr3ALUy2Ehb+jDqtr2dpRRcd9ugaeJaePM84jSgNnWfo7b6 owAA6Yabf9pZ2CECadWlx2Vf/UcEBe3Ru/Hg8eXnI3Od9skjqLcVzLQYwMKdHLP1FjTf UXYVjUdCfgJtyqHqmkXXSPNvKzWc7/4OhrDx4gVDizRY6QqTXT5ADTSEwm8EW6X4NsiK KfeXgor2I58mOMbFMQYxJ6eRaDl5r+ueK7+ScH5nlJkkcOYGasQrSdjuHKcsvRFOpkbH csUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0j3bPtwVUVm/jZDBUJXolF4U+AmslpUbr8sCL6VPfoA=; b=IJNpsqt3zk5KaPbxIFLFQ+jhjvr05yRBLqGv2rQ9ocJiMBXxwbaLHmZhRlCDsNIchA JcfEQ1iCN+3sbjQI7Uvo7zOMmPEN8n6TpTyYTYGr3NNePgJUKZDZzeHzT9RiCdp+h09y Pw36lzkJhH3oiFnjN9BnSaJxPGUQ9vNtWrdk9GExsUsuAXYVE/19MAsEkUitPqtgtd6H Z+/8nMO0LOi75icOiMcZzc4k+h9vYA8+JOBXkWMjP0biyZsBLmNn5KygDbIxVVIyomyB Zab3hvOqPuyR7Qu0C3pC/svT3Ugx4ozWqahHIrWX4gqZByrNyafRZpG+1JH+fKCzTB3m 5XBg== X-Gm-Message-State: AOAM531dWdSsOypVmB2TvNueA8d45hOLyzY8uHsSP6IsYEbXXGQqIZqb 2BMfZ7RNiEaWhy/AlV456oQjvQ== X-Google-Smtp-Source: ABdhPJw9FCFTdkiAN4LxfJoUs++5xlLWx8lVhaIJEWeX7hAEofC+sahFp6Ki2Mrs5oqdp3xuqh93zw== X-Received: by 2002:adf:a2c3:: with SMTP id t3mr33970462wra.223.1626775765602; Tue, 20 Jul 2021 03:09:25 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:83e0:11ac:c870:2b97]) by smtp.gmail.com with ESMTPSA id m15sm19470088wmc.20.2021.07.20.03.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 03:09:25 -0700 (PDT) Date: Tue, 20 Jul 2021 11:09:21 +0100 From: Quentin Perret To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, will@kernel.org, dbrazdil@google.com, Srivatsa Vaddagiri , Shanker R Donthineni , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 03/16] KVM: arm64: Turn kvm_pgtable_stage2_set_owner into kvm_pgtable_stage2_annotate Message-ID: References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-4-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715163159.1480168-4-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thursday 15 Jul 2021 at 17:31:46 (+0100), Marc Zyngier wrote: > @@ -815,7 +807,7 @@ int kvm_pgtable_stage2_set_owner(struct kvm_pgtable *pgt, u64 addr, u64 size, > .arg = &map_data, > }; > > - if (owner_id > KVM_MAX_OWNER_ID) > + if (!annotation || (annotation & PTE_VALID)) > return -EINVAL; Why do you consider annotation==0 invalid? The assumption so far has been that the owner_id for the host is 0, so annotating a range with 0s should be a valid operation -- this will be required when e.g. transferring ownership of a page back to the host. > > ret = kvm_pgtable_walk(pgt, addr, size, &walker); > -- > 2.30.2 >