From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
Date: Tue, 20 Jul 2021 15:51:35 +0200 [thread overview]
Message-ID: <YPbU59Kmpk0NvlQH@lunn.ch> (raw)
In-Reply-To: <E1m5mVT-00032g-Km@rmk-PC.armlinux.org.uk>
On Tue, Jul 20, 2021 at 10:57:43AM +0100, Russell King wrote:
> Phylink documentation says:
> Note that the PHY may be able to transform from one connection
> technology to another, so, eg, don't clear 1000BaseX just
> because the MAC is unable to BaseX mode. This is more about
> clearing unsupported speeds and duplex settings. The port modes
> should not be cleared; phylink_set_port_modes() will help with this.
>
> So add the missing 10G modes.
Hi Russell
Would a phylink_set_10g(mask) helper make sense? As you say, it is
about the speed, not the individual modes.
Andrew
next prev parent reply other threads:[~2021-07-20 13:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 9:57 [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Russell King
2021-07-20 13:51 ` Andrew Lunn [this message]
2021-07-20 14:11 ` Russell King (Oracle)
2021-07-20 14:13 ` Andrew Lunn
2021-08-16 14:47 ` Ioana Ciornei
2021-09-03 10:33 ` Russell King (Oracle)
2021-09-03 11:09 ` Ioana Ciornei
2021-09-03 11:34 ` Russell King (Oracle)
2021-09-03 13:11 ` Andrew Lunn
2021-09-03 17:06 ` Ioana Ciornei
2021-07-20 14:13 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2021-03-09 15:35 Russell King
2021-03-10 2:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPbU59Kmpk0NvlQH@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.