From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA1C3C07E95 for ; Tue, 20 Jul 2021 14:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE4C461208 for ; Tue, 20 Jul 2021 14:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239487AbhGTNfi (ORCPT ); Tue, 20 Jul 2021 09:35:38 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36304 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239126AbhGTNcr (ORCPT ); Tue, 20 Jul 2021 09:32:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=H/ZSBjInAi13UtQwysE1XGWP1x1Z2LWyhWVDwlfUhQ4=; b=1g QzmAfqTWm5Y4pgEztIhcBInugL8LFRLZ+hgt4A1LWL8PGnfxPcif9vWqkdeQEn8hzHdXjbGd2YX2r hBokjL0CI1uz+fqpjRNhyz87aA3viInW5FdbnQPf/6zbiOw65D5cf5AxlYTV+oRTGEiv/iEeBqtxv Y11RkqUcqBO2QoE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m5qUu-00E3xa-EZ; Tue, 20 Jul 2021 16:13:24 +0200 Date: Tue, 20 Jul 2021 16:13:24 +0200 From: Andrew Lunn To: Russell King Cc: Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, Ioana Ciornei , Jakub Kicinski Subject: Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 20, 2021 at 10:57:43AM +0100, Russell King wrote: > Phylink documentation says: > Note that the PHY may be able to transform from one connection > technology to another, so, eg, don't clear 1000BaseX just > because the MAC is unable to BaseX mode. This is more about > clearing unsupported speeds and duplex settings. The port modes > should not be cleared; phylink_set_port_modes() will help with this. > > So add the missing 10G modes. > > Signed-off-by: Russell King > Acked-by: Marek Behún > Acked-by: Ioana Ciornei Reviewed-by: Andrew Lunn Andrew