From: Kevin Wolf <kwolf@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block <qemu-block@nongnu.org>,
Wen Congyang <wencongyang2@huawei.com>,
Xie Changlong <xiechanglong.d@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v6 0/4] replication: Bugfix and properly attach children
Date: Tue, 20 Jul 2021 16:25:31 +0200 [thread overview]
Message-ID: <YPbc23vJhDDeT+4a@redhat.com> (raw)
In-Reply-To: <cover.1626619393.git.lukasstraub2@web.de>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
Am 18.07.2021 um 16:48 hat Lukas Straub geschrieben:
> Hello Everyone,
> A while ago Kevin noticed that the replication driver doesn't properly attach
> the children it wants to use. Instead, it directly copies the BdrvChilds from
> it's backing file, which is wrong. Ths Patchset fixes the problem, fixes a
> potential crash in replication_co_writev due to missing permissions and removes
> a workaround that was put in place back then.
>
> Tested with full COLO-migration setup in my COLO testsuite.
Thanks for taking care of this, Lukas!
I've applied the series to the block branch.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-07-20 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 14:48 [PATCH v6 0/4] replication: Bugfix and properly attach children Lukas Straub
2021-07-18 14:48 ` [PATCH v6 1/4] replication: Remove s->active_disk Lukas Straub
2021-07-19 2:26 ` Zhang, Chen
2021-07-18 14:48 ` [PATCH v6 2/4] replication: Reduce usage of s->hidden_disk and s->secondary_disk Lukas Straub
2021-07-18 14:48 ` [PATCH v6 3/4] replication: Properly attach children Lukas Straub
2021-07-18 14:48 ` [PATCH v6 4/4] replication: Remove workaround Lukas Straub
2021-07-20 14:25 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPbc23vJhDDeT+4a@redhat.com \
--to=kwolf@redhat.com \
--cc=lukasstraub2@web.de \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.