Re: [PATCH 06/10] drm/bridge: panel: Call attach and detach for the panel

[Sam Ravnborg <sam@ravnborg.org>]

On Tue, Jul 20, 2021 at 03:45:21PM +0200, Maxime Ripard wrote:
> Now that we have additional attach and detach hooks for panels, make
> sure that the panel bridge driver calls them when relevant.

Combine this with the previous patch as this is again a partial revert of
the same patch.

	Sam
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  drivers/gpu/drm/bridge/panel.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index c916f4b8907e..c2249f3fd357 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -60,6 +60,8 @@ static int panel_bridge_attach(struct drm_bridge *bridge,
>  	struct drm_connector *connector = &panel_bridge->connector;
>  	int ret;
>  
> +	drm_panel_attach(panel_bridge->panel);
attach can fail...

> +
>  	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
>  		return 0;
>  
> @@ -90,6 +92,8 @@ static void panel_bridge_detach(struct drm_bridge *bridge)
>  	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
>  	struct drm_connector *connector = &panel_bridge->connector;
>  
> +	drm_panel_detach(panel_bridge->panel);
> +
>  	/*
>  	 * Cleanup the connector if we know it was initialized.
>  	 *
> -- 
> 2.31.1