From: Phillip Potter <phil@philpotter.co.uk>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, gregkh@linuxfoundation.org
Subject: Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory
Date: Tue, 20 Jul 2021 23:51:19 +0100 [thread overview]
Message-ID: <YPdTZ9Q9zCIyBjjB@equinox> (raw)
In-Reply-To: <7bc43fb0-2dab-190b-c480-9e77cff863d4@lwfinger.net>
On Mon, Jul 19, 2021 at 06:46:16PM -0500, Larry Finger wrote:
> On 7/19/21 5:46 PM, Phillip Potter wrote:
> > Move all C source files from the core subdirectory to the root
> > folder of the driver, and adjust Makefile accordingly. The ultmate
> > goal is to remove hal layer and fold its functionalty into the main
> > sources. At this point, the distinction between hal and core will be
> > meaningless, so this is the first step towards simplifying the file
> > layout.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> > drivers/staging/rtl8188eu/Makefile | 34 +++++++++----------
> > drivers/staging/rtl8188eu/{core => }/rtw_ap.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_cmd.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_efuse.c | 0
> > .../rtl8188eu/{core => }/rtw_ieee80211.c | 0
> > .../rtl8188eu/{core => }/rtw_ioctl_set.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_iol.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_led.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_mlme.c | 0
> > .../rtl8188eu/{core => }/rtw_mlme_ext.c | 0
> > .../rtl8188eu/{core => }/rtw_pwrctrl.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_recv.c | 0
> > drivers/staging/rtl8188eu/{core => }/rtw_rf.c | 0
> > .../rtl8188eu/{core => }/rtw_security.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_sreset.c | 0
> > .../rtl8188eu/{core => }/rtw_sta_mgt.c | 0
> > .../rtl8188eu/{core => }/rtw_wlan_util.c | 0
> > .../staging/rtl8188eu/{core => }/rtw_xmit.c | 0
> > 18 files changed, 17 insertions(+), 17 deletions(-)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_ap.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_cmd.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_efuse.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_ieee80211.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_ioctl_set.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_iol.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_led.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_mlme.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_mlme_ext.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_pwrctrl.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_recv.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_rf.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_security.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_sreset.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_sta_mgt.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_wlan_util.c (100%)
> > rename drivers/staging/rtl8188eu/{core => }/rtw_xmit.c (100%)
> >
> > diff --git a/drivers/staging/rtl8188eu/Makefile b/drivers/staging/rtl8188eu/Makefile
> > index 28b936e8be0a..2dad13bdbdeb 100644
> > --- a/drivers/staging/rtl8188eu/Makefile
> > +++ b/drivers/staging/rtl8188eu/Makefile
> > @@ -1,22 +1,22 @@
> > # SPDX-License-Identifier: GPL-2.0
> > r8188eu-y := \
> > - core/rtw_ap.o \
> > - core/rtw_cmd.o \
> > - core/rtw_efuse.o \
> > - core/rtw_ieee80211.o \
> > - core/rtw_ioctl_set.o \
> > - core/rtw_iol.o \
> > - core/rtw_led.o \
> > - core/rtw_mlme.o \
> > - core/rtw_mlme_ext.o \
> > - core/rtw_pwrctrl.o \
> > - core/rtw_recv.o \
> > - core/rtw_rf.o \
> > - core/rtw_security.o \
> > - core/rtw_sreset.o \
> > - core/rtw_sta_mgt.o \
> > - core/rtw_wlan_util.o \
> > - core/rtw_xmit.o \
> > + rtw_ap.o \
> > + rtw_cmd.o \
> > + rtw_efuse.o \
> > + rtw_ieee80211.o \
> > + rtw_ioctl_set.o \
> > + rtw_iol.o \
> > + rtw_led.o \
> > + rtw_mlme.o \
> > + rtw_mlme_ext.o \
> > + rtw_pwrctrl.o \
> > + rtw_recv.o \
> > + rtw_rf.o \
> > + rtw_security.o \
> > + rtw_sreset.o \
> > + rtw_sta_mgt.o \
> > + rtw_wlan_util.o \
> > + rtw_xmit.o \
> > hal/fw.o \
> > hal/mac_cfg.o \
> > hal/bb_cfg.o \
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/rtw_ap.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_ap.c
> > rename to drivers/staging/rtl8188eu/rtw_ap.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/rtw_cmd.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_cmd.c
> > rename to drivers/staging/rtl8188eu/rtw_cmd.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/rtw_efuse.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_efuse.c
> > rename to drivers/staging/rtl8188eu/rtw_efuse.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/rtw_ieee80211.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_ieee80211.c
> > rename to drivers/staging/rtl8188eu/rtw_ieee80211.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/rtw_ioctl_set.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
> > rename to drivers/staging/rtl8188eu/rtw_ioctl_set.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/rtw_iol.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_iol.c
> > rename to drivers/staging/rtl8188eu/rtw_iol.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/rtw_led.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_led.c
> > rename to drivers/staging/rtl8188eu/rtw_led.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/rtw_mlme.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_mlme.c
> > rename to drivers/staging/rtl8188eu/rtw_mlme.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/rtw_mlme_ext.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> > rename to drivers/staging/rtl8188eu/rtw_mlme_ext.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/rtw_pwrctrl.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> > rename to drivers/staging/rtl8188eu/rtw_pwrctrl.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/rtw_recv.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_recv.c
> > rename to drivers/staging/rtl8188eu/rtw_recv.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_rf.c b/drivers/staging/rtl8188eu/rtw_rf.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_rf.c
> > rename to drivers/staging/rtl8188eu/rtw_rf.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/rtw_security.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_security.c
> > rename to drivers/staging/rtl8188eu/rtw_security.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c b/drivers/staging/rtl8188eu/rtw_sreset.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_sreset.c
> > rename to drivers/staging/rtl8188eu/rtw_sreset.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/rtw_sta_mgt.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> > rename to drivers/staging/rtl8188eu/rtw_sta_mgt.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/rtw_wlan_util.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> > rename to drivers/staging/rtl8188eu/rtw_wlan_util.c
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/rtw_xmit.c
> > similarity index 100%
> > rename from drivers/staging/rtl8188eu/core/rtw_xmit.c
> > rename to drivers/staging/rtl8188eu/rtw_xmit.c
> >
>
> I think this is just source churning. The current setup with include. core.
> hal and os_dep subdirectories are not opressive.
>
> Larry
>
Dear Larry,
Thank you for your feedback. I will focus on utilising the existing
folder structure in that case, with a view towards reducing/removing the
'hal' folder and reintegrating its code.
Regards,
Phil
next prev parent reply other threads:[~2021-07-20 22:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 22:46 [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory Phillip Potter
2021-07-19 23:46 ` Larry Finger
2021-07-20 9:00 ` Fabio Aiuto
2021-07-20 22:54 ` Phillip Potter
2021-07-21 7:51 ` Fabio Aiuto
2021-07-21 0:22 ` Larry Finger
2021-07-21 7:47 ` Fabio Aiuto
2021-07-21 7:49 ` Phillip Potter
2021-07-21 17:33 ` Larry Finger
2021-07-21 18:28 ` Dan Carpenter
2021-07-21 19:18 ` Larry Finger
2021-07-22 10:44 ` Phillip Potter
2021-07-22 13:28 ` Greg KH
2021-07-22 16:30 ` Larry Finger
2021-07-22 22:12 ` Phillip Potter
2021-07-20 22:51 ` Phillip Potter [this message]
2021-07-21 8:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPdTZ9Q9zCIyBjjB@equinox \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.