From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata
Date: Wed, 21 Jul 2021 11:25:47 +0200 [thread overview]
Message-ID: <YPfoGzCtS7sBFESm@kroah.com> (raw)
In-Reply-To: <723edefbb2e9ce0b70d9c7bce95f288e3ea1f5b1.1626515862.git.mchehab+huawei@kernel.org>
On Sat, Jul 17, 2021 at 11:58:16AM +0200, Mauro Carvalho Chehab wrote:
> There are lots of fields at struct hi6421_spmi_pmic that aren't
> used. In a matter of fact, only regmap is needed.
>
> So, drop the struct as a hole, and set just the regmap as
> the drvdata.
>
> While here, add a missing dot at the Huawei's copyrights.
>
> Acked-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/misc/hi6421v600-irq.c | 9 ++++----
> drivers/regulator/hi6421v600-regulator.c | 10 ++++-----
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++--------
> include/linux/mfd/hi6421-spmi-pmic.h | 25 ---------------------
> 4 files changed, 14 insertions(+), 46 deletions(-)
> delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h
This patch fails to apply to my 5.14-rc2 tree, it gets a failure in the
regulator portion of the patch.
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-21 9:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 9:58 [PATCH v14 0/9] Move Hisilicon 6421v600 SPMI and USB drivers out of staging Mauro Carvalho Chehab
2021-07-17 9:58 ` Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 1/9] staging: hi6421-spmi-pmic: rename spmi_device struct Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 2/9] staging: hi6421-spmi-pmic: rename GPIO IRQ OF node Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 3/9] staging: hi6421-spmi-pmic: add a missing dot at copyright Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 4/9] staging: hikey9xx: split hi6421v600 irq into a separate driver Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata Mauro Carvalho Chehab
2021-07-21 9:25 ` Greg Kroah-Hartman [this message]
2021-07-21 10:10 ` Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 6/9] staging: hisilicon,hi6421-spmi-pmic.yaml: fix patternProperties Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 7/9] mfd: hi6421-spmi-pmic: move driver from staging Mauro Carvalho Chehab
2021-07-19 10:55 ` Lee Jones
2021-07-19 11:45 ` Mauro Carvalho Chehab
2021-07-19 13:26 ` Lee Jones
2021-07-17 9:58 ` [PATCH v14 8/9] dts: hisilicon: add support for the PMIC found on Hikey 970 Mauro Carvalho Chehab
2021-07-17 9:58 ` Mauro Carvalho Chehab
2021-07-17 9:58 ` [PATCH v14 9/9] dts: hisilicon: add support for USB3 " Mauro Carvalho Chehab
2021-07-17 9:58 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPfoGzCtS7sBFESm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.