All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	John Garry <john.garry@huawei.com>,
	Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
	Wen Xiong <wenxiong@us.ibm.com>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH V5 2/3] blk-mq: mark if one queue map uses managed irq
Date: Thu, 22 Jul 2021 09:24:48 +0800	[thread overview]
Message-ID: <YPjI4N5qsuRgPHS4@T590> (raw)
In-Reply-To: <20210721143716.GB11058@lst.de>

On Wed, Jul 21, 2021 at 04:37:16PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 05:17:22PM +0800, Ming Lei wrote:
> > +	/* So far RDMA doesn't use managed irq */
> > +	map->use_managed_irq = false;
> 
> It certainly did when I wrote this code.  The comment should be
> something "sigh, someone fucked up the rdma queue mapping.  No managed
> irqs for now".

But if it rdma queue mapping uses managed irq, the issue in blk_mq_alloc_request_hctx()
can be hard to fix, :-(


Thanks,
Ming


  reply	other threads:[~2021-07-22  1:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  9:17 [PATCH V5 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-21  9:17 ` [PATCH V5 1/3] driver core: add device_has_managed_msi_irq Ming Lei
2021-07-21 13:48   ` Greg Kroah-Hartman
2021-07-21 14:36   ` Christoph Hellwig
2021-07-21  9:17 ` [PATCH V5 2/3] blk-mq: mark if one queue map uses managed irq Ming Lei
2021-07-21 14:37   ` Christoph Hellwig
2021-07-22  1:24     ` Ming Lei [this message]
2021-07-21 18:53   ` John Garry
2021-07-22  1:22     ` Ming Lei
2021-07-21  9:17 ` [PATCH V5 3/3] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-07-21 14:37   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPjI4N5qsuRgPHS4@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=john.garry@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=sagi@grimberg.me \
    --cc=tglx@linutronix.de \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.