From: Raul E Rangel <rrangel@chromium.org>
To: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
Cc: Alexander.Deucher@amd.com, amd-gfx@lists.freedesktop.org
Subject: Re: drm/amdgpu: Check pmops for desired suspend state
Date: Thu, 22 Jul 2021 08:42:37 -0600 [thread overview]
Message-ID: <YPmD3YEmxIZAVQbB@google.com> (raw)
In-Reply-To: <20210722052714.626304-1-Pratik.Vishwakarma@amd.com>
On Thu, Jul 22, 2021 at 10:57:14AM +0530, Pratik Vishwakarma wrote:
> [Why]
> User might set mem_sleep as deep and it will result
> in amdgpu resume errors.
>
> [How]
> Check with pm for default suspend state
>
> Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index af1710971ff3..d92196429741 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,7 +1468,8 @@ static int amdgpu_pmops_suspend(struct device *dev)
> struct amdgpu_device *adev = drm_to_adev(drm_dev);
> int r;
>
> - if (amdgpu_acpi_is_s0ix_supported(adev))
> + if (amdgpu_acpi_is_s0ix_supported(adev)
> + && pm_suspend_default_s2idle())
Why pm_suspend_default_s2idle instead of pm_suspend_via_firmware?
> adev->in_s0ix = true;
> adev->in_s3 = true;
> r = amdgpu_device_suspend(drm_dev, true);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-07-22 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 5:27 [PATCH] drm/amdgpu: Check pmops for desired suspend state Pratik Vishwakarma
2021-07-22 14:42 ` Raul E Rangel [this message]
2021-07-22 17:12 ` Deucher, Alexander
2021-07-23 4:10 ` Lazar, Lijo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPmD3YEmxIZAVQbB@google.com \
--to=rrangel@chromium.org \
--cc=Alexander.Deucher@amd.com \
--cc=Pratik.Vishwakarma@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.