From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA745C6377D for ; Thu, 22 Jul 2021 14:52:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66DB861221 for ; Thu, 22 Jul 2021 14:52:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66DB861221 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6a3V-00017Q-Kv for qemu-devel@archiver.kernel.org; Thu, 22 Jul 2021 10:52:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6a2U-00083J-0h for qemu-devel@nongnu.org; Thu, 22 Jul 2021 10:51:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6a2S-0006vL-IC for qemu-devel@nongnu.org; Thu, 22 Jul 2021 10:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626965464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yxwzf6wDvutQNyQmAOK7VwhpyzPMuO1hyML1FMOpZi4=; b=UOnc9VZl5YLOvE6KKBnVJAqVtpEOIhObdDYs9Zf80cbMFBgkkPjKc89a9xNZ5dTOTNr6Q3 1mq5S/fP3rpX5vGuLPaeeDIKHb6qa4d8pO2a1j2LO493q+wugKLH5fz0kurlIFaOKNFt1s PcvTmNuEiyQzqCqETfrswOPpLPD31oA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-eLyA1BqPNGmK5YBBT8c9eQ-1; Thu, 22 Jul 2021 10:51:02 -0400 X-MC-Unique: eLyA1BqPNGmK5YBBT8c9eQ-1 Received: by mail-qv1-f72.google.com with SMTP id kj25-20020a0562145299b02902fbda5d4988so3814115qvb.11 for ; Thu, 22 Jul 2021 07:51:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yxwzf6wDvutQNyQmAOK7VwhpyzPMuO1hyML1FMOpZi4=; b=HeILT8tzpYvWziO1h3cWeze2o7+YMuFcOuc0wsvcAd2kfBYgwr8KuRHpSHi3V8GPyO 4yTZsJXTK2i9IBUHEz+rq/yvhXcvjWdDAbEg7JEVpFCranB3N01jiQWbTwHffZVTkfZd DNB+4zVFZMoDmcI2ORbsgkVWTK8i988C0pL+642pA53lPUtUTRM9vQaAOF7YekGXeuhZ y44jfoYI1hmkCzFStncQyxsSqOZazeFpo0lWcZf423uKmOeAVrMVWhrsZfriIk2FtHzk 66evvvOJJCfOiZHH7D7ppJwjC8C31nNh4h6f5Q1ucOvkts8kY/tr8csqNTOqPtuHHeOz Z0Lw== X-Gm-Message-State: AOAM533en5iwPHkmCoOGjKAREvK1y4VUTqaCtAku8oupEtUcWdS6gUYQ ELmdCAFeX4x+vLOQLkZHwRljIuMtZHKk9GPTkzBpWouwGaoRgAbfEimOaWvsGVu+/XQPtdvy9gN VP9q4trW9tJe4ZQw= X-Received: by 2002:a37:9d12:: with SMTP id g18mr29545qke.457.1626965462378; Thu, 22 Jul 2021 07:51:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9Q1vmh92dsTl3wNw9fQkZzx5Owo424UL1PM58pbkCnEqplTBYJgdGO03ahsqEESxS1uCx9g== X-Received: by 2002:a37:9d12:: with SMTP id g18mr29525qke.457.1626965462200; Thu, 22 Jul 2021 07:51:02 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id r4sm10670772qtc.66.2021.07.22.07.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jul 2021 07:51:01 -0700 (PDT) Date: Thu, 22 Jul 2021 10:51:00 -0400 From: Peter Xu To: "Wang, Wei W" Subject: Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages Message-ID: References: <20210722083055.23352-1-wei.w.wang@intel.com> <0faf5f01-399f-621f-431e-d35b3e87b9ff@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.472, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "quintela@redhat.com" , "mst@redhat.com" , "qemu-devel@nongnu.org" , "dgilbert@redhat.com" , David Hildenbrand Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 22, 2021 at 09:57:13AM +0000, Wang, Wei W wrote: > On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote: > > On 22.07.21 10:30, Wei Wang wrote: > > > When skipping free pages to send, their corresponding dirty bits in > > > the memory region dirty bitmap need to be cleared. Otherwise the > > > skipped pages will be sent in the next round after the migration > > > thread syncs dirty bits from the memory region dirty bitmap. > > > > > > Cc: David Hildenbrand > > > Cc: Peter Xu > > > Cc: Michael S. Tsirkin > > > Reported-by: David Hildenbrand > > > Signed-off-by: Wei Wang > > > --- > > > migration/ram.c | 74 > > +++++++++++++++++++++++++++++++++++++------------ > > > 1 file changed, 56 insertions(+), 18 deletions(-) > > > > > > > LGTM, thanks > > > > Reviewed-by: David Hildenbrand > > > > Thanks. Please remember to have a regression test together with Peterx's that patch when you get a chance. I can continue to try that; but it's slightly low priority to me so it could be a bit delayed. If either of you could help that would be great, as I still don't know last time why I didn't use free-page-hint right (note: I definitely checked lsmod for sure; so it's there). So I'll need to figure that out first. Thanks, -- Peter Xu