From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
rafael@kernel.org, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 0/2] Check for endpoints in fwnode->secondary more sensibly
Date: Fri, 23 Jul 2021 15:33:34 +0300 [thread overview]
Message-ID: <YPq3HvKWvChRp45A@smile.fi.intel.com> (raw)
In-Reply-To: <20210722201929.3585671-1-djrscally@gmail.com>
On Thu, Jul 22, 2021 at 09:19:27PM +0100, Daniel Scally wrote:
> Hello all
>
> A while ago I patched fwnode_graph_get_endpoint_by_id() to check for endpoints
> against fwnode->secondary if none was found against the primary. It's actually
> better to do this in fwnode_graph_get_next_endpoint() instead, since that
> function is called by fwnode_graph_get_endpoint_by_id() and also directly called
> in a bunch of other places (primarily sensor drivers checking that they have
> endpoints connected during probe). This small series just adds the equivalent
> functionality to fwnode_graph_get_next_endpoint() and reverts the earlier
> commit.
Makes sense to me (one nit-pick to patch 1, though).
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Daniel Scally (2):
> device property: Check fwnode->secondary in
> fwnode_graph_get_next_endpoint()
> Revert "media: device property: Call fwnode_graph_get_endpoint_by_id()
> for fwnode->secondary"
>
> drivers/base/property.c | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-07-23 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 20:19 [PATCH 0/2] Check for endpoints in fwnode->secondary more sensibly Daniel Scally
2021-07-22 20:19 ` [PATCH 1/2] device property: Check fwnode->secondary in fwnode_graph_get_next_endpoint() Daniel Scally
2021-07-23 12:32 ` Andy Shevchenko
2021-07-23 13:04 ` Daniel Scally
2021-07-30 11:34 ` Andy Shevchenko
2021-07-31 21:36 ` Daniel Scally
2021-07-22 20:19 ` [PATCH 2/2] Revert "media: device property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary" Daniel Scally
2021-07-23 12:33 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPq3HvKWvChRp45A@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.