From: Greg KH <gregkh@linuxfoundation.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: stable@vger.kernel.org, davem@davemloft.net, jishi@redhat.com
Subject: Re: [PATCH 4.19] net: ip_tunnel: fix mtu calculation for ETHER tunnel devices
Date: Fri, 23 Jul 2021 14:11:45 +0200 [thread overview]
Message-ID: <YPqyAW86HAnxxezf@kroah.com> (raw)
In-Reply-To: <20210723020031.343268-1-liuhangbin@gmail.com>
On Fri, Jul 23, 2021 at 10:00:31AM +0800, Hangbin Liu wrote:
> commit 9992a078b1771da354ac1f9737e1e639b687caa2 upstream.
>
> Commit 28e104d00281 ("net: ip_tunnel: fix mtu calculation") removed
> dev->hard_header_len subtraction when calculate MTU for tunnel devices
> as there is an overhead for device that has header_ops.
>
> But there are ETHER tunnel devices, like gre_tap or erspan, which don't
> have header_ops but set dev->hard_header_len during setup. This makes
> pkts greater than (MTU - ETH_HLEN) could not be xmited. Fix it by
> subtracting the ETHER tunnel devices' dev->hard_header_len for MTU
> calculation.
>
> Fixes: 28e104d00281 ("net: ip_tunnel: fix mtu calculation")
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> net/ipv4/ip_tunnel.c | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
Applied, thanks.
greg k-h
prev parent reply other threads:[~2021-07-23 12:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:24 FAILED: patch "[PATCH] net: ip_tunnel: fix mtu calculation for ETHER tunnel devices" failed to apply to 4.19-stable tree gregkh
2021-07-23 2:00 ` [PATCH 4.19] net: ip_tunnel: fix mtu calculation for ETHER tunnel devices Hangbin Liu
2021-07-23 12:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPqyAW86HAnxxezf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=jishi@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.