All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Artem Baxtiarov <baxtiarovartem@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: comedi: drivers: ni_routing: ni_device_routes: pci-6070e.c Lindented
Date: Fri, 23 Jul 2021 15:18:00 +0200	[thread overview]
Message-ID: <YPrBiNPdeyTfpkUE@kroah.com> (raw)
In-Reply-To: <20210723122749.GA41336@ideapad>

On Fri, Jul 23, 2021 at 03:27:49PM +0300, Artem Baxtiarov wrote:
> I found "Lindent" item in drivers/comedi/TODO.
> I used scripts/Lindent to indent

Please never use that on files.  checkpatch is what you should be using
for this, and odds are the TODO file should just be removed instead.

> drivers/comedi/drivers/ni_routing/ni_device_routes/pci-6070e.c

If you look, your changes make the code harder to read, sorry, but this
isn't needed.

thanks,

greg k-h

  reply	other threads:[~2021-07-23 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 12:27 [PATCH] Drivers: comedi: drivers: ni_routing: ni_device_routes: pci-6070e.c Lindented Artem Baxtiarov
2021-07-23 13:18 ` Greg KH [this message]
2021-07-23 13:31 ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPrBiNPdeyTfpkUE@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=baxtiarovartem@gmail.com \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.