From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyaprateek2357@gmail.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v4 0/9] ensure bios aren't split in middle of crypto data unit
Date: Fri, 23 Jul 2021 10:52:26 -0700 [thread overview]
Message-ID: <YPsB2vsJPobULxO0@gmail.com> (raw)
In-Reply-To: <YPrzMI6P7MzO3V3K@gmail.com>
On Fri, Jul 23, 2021 at 09:49:52AM -0700, Eric Biggers wrote:
> On Tue, Jul 06, 2021 at 10:29:34PM -0700, Satya Tangirala wrote:
> >
> > Changes v3 => v4
> > - Patch 4 in v3 has been removed (Eric points out it isn't required
> > without some of the changes in the device mapper patchset at
> > https://lore.kernel.org/linux-block/20210604210908.2105870-1-satyat@google.com/
> > so I'll add this patch to that series instead.
>
> Wouldn't it make more sense to have the blk-crypto-fallback change in this
> series? My concern was just that it didn't make sense to have it split between
> the two patch series -- it seemed like one logical change.
This series also doesn't actually remove the data_unit_size bvec alignment
requirement from block/blk-crypto.c. Isn't that the main goal here? So I
expected that it would be included.
Unless there are special considerations here, I'd expect that all the block
layer changes needed for the fscrypt direct I/O support would be in one patch
series that could go in together, and then the patch series with the direct I/O
support would be only filesystem layer changes.
- Eric
next prev parent reply other threads:[~2021-07-23 17:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 5:29 [PATCH v4 0/9] ensure bios aren't split in middle of crypto data unit Satya Tangirala
2021-07-07 5:29 ` [PATCH v4 1/9] block: introduce blk_ksm_is_empty() Satya Tangirala
2021-07-23 16:45 ` Eric Biggers
2021-07-07 5:29 ` [PATCH v4 2/9] block: blk-crypto: introduce blk_crypto_bio_sectors_alignment() Satya Tangirala
2021-07-23 16:45 ` Eric Biggers
2021-07-07 5:29 ` [PATCH v4 3/9] block: introduce bio_required_sector_alignment() Satya Tangirala
2021-07-23 16:46 ` Eric Biggers
2021-07-07 5:29 ` [PATCH v4 4/9] block: keyslot-manager: introduce blk_ksm_restrict_dus_to_queue_limits() Satya Tangirala
2021-07-23 17:08 ` Eric Biggers
2021-07-07 5:29 ` [PATCH v4 5/9] ufshcd: handle error from blk_ksm_register() Satya Tangirala
2021-07-23 17:13 ` Eric Biggers
2021-07-07 5:29 ` [PATCH v4 6/9] mmc: " Satya Tangirala
2021-07-07 5:29 ` [PATCH v4 7/9] dm: " Satya Tangirala
2021-07-23 17:26 ` Eric Biggers
2021-07-07 5:29 ` [PATCH v4 8/9] blk-merge: Ensure bios aren't split in middle of a crypto data unit Satya Tangirala
2021-07-23 18:11 ` Eric Biggers
2021-07-07 5:29 ` [PATCH v4 9/9] block: add WARN_ON_ONCE() to bio_split() for sector alignment Satya Tangirala
2021-07-23 17:30 ` Eric Biggers
2021-07-23 16:49 ` [PATCH v4 0/9] ensure bios aren't split in middle of crypto data unit Eric Biggers
2021-07-23 17:52 ` Eric Biggers [this message]
2021-07-24 7:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPsB2vsJPobULxO0@gmail.com \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satyaprateek2357@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.