From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D713C4338F for ; Fri, 6 Aug 2021 13:38:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7091961179 for ; Fri, 6 Aug 2021 13:38:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7091961179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5D0A216C6; Fri, 6 Aug 2021 15:37:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5D0A216C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628257091; bh=+M/KNvCrPjIixoNusBjYzcT2MzQ/5x3p3yP3fk3XRuo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AYtOjwa+89PXyyfaOGRjIz+cEDDe2RcBu2u2TmqWOmLgqXd16C7n9bL13IXizuD3b mC2LtcpaHFqMGUgT8G9QhJcfqnj+oxws/8NRThsySch+lfgauR8SFeqQ0WW2qo2D9x 5/StWqDZTVwlqNa/0HrtsR5BoPU6tkuaaZ84jGBk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 95CB6F8010A; Fri, 6 Aug 2021 15:37:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 19907F8025F; Fri, 6 Aug 2021 15:37:19 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 814A5F8010A for ; Fri, 6 Aug 2021 15:37:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 814A5F8010A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ubZYUm1O" Received: by mail.kernel.org (Postfix) with ESMTPSA id C13AA60E09; Fri, 6 Aug 2021 13:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628257033; bh=+M/KNvCrPjIixoNusBjYzcT2MzQ/5x3p3yP3fk3XRuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ubZYUm1OwKbZFJB7VdLYH76TC9U6A06Uo5+csyowasuBZwAeq5hFxWcgx9jL79HuQ atVAIityhCDmk9kI42krsKU4O9/RN2pvnMOKmHn/1fagyS60n1MnOxVcTG9kmbhoSC hw95k/YnEQW0CSEcU7qojUuY/0UJtVENYzYyJBCPcqoSigeK3RUjJGxng2P05jLnkc tpXeApfKaASvIGTvlKqV6aSmC/WPbgkZacm8j4cEadOOvifsExB3+u7JwLuxzk3RU4 Ih22RMrcWnR6rc5461GPYUB26aIGO6DiaLyroRmKZjNlIqaWuxZpmk41YLOMzMBCDz JjKpnJxfa90sQ== Date: Fri, 6 Aug 2021 19:07:09 +0530 From: Vinod Koul To: Pierre-Louis Bossart Subject: Re: [PATCH] soundwire: intel: trap TRIGGER_SUSPEND in .trigger callback Message-ID: References: <20210727053256.29949-1-yung-chuan.liao@linux.intel.com> <9ef7e341-13f4-69f7-964d-8e6efdd57ca7@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ef7e341-13f4-69f7-964d-8e6efdd57ca7@linux.intel.com> Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Ranjani Sridharan , "broonie@kernel.org" , Bard Liao , "Liao, Bard" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 02-08-21, 10:46, Pierre-Louis Bossart wrote: > > >>>>>> The trigger callback is handled in the stream lock atomically, > >>>>>> and are you sure that you want to operate a possibly heavy task there? > >>>>> > >>>>> It's a good objection that we didn't think of. > >>>> > >>>> Doesn't Intel use non atomic trigger to send IPCs which anyway > >>>> involve code which can sleep..? > >>> > >>> sof_sdw.c doesn't seem setting it? > >> > >> Yes I think init_dai_link() should set it. Maybe Pierre/Bard would know why. > > > > init_dai_link() is to assign dai link elements only. No IPC is needed. > > The 'nonatomic' concept is only used for an FE dailink which expose a > PCM device: > > soc-pcm.c: pcm->nonatomic = rtd->dai_link->nonatomic; > > Setting a BE dailink as 'nonatomic' would not accomplish much since BEs > use the 'no_pcm' option. are no_pcm & nonatomic supposed to be not used together? So if FE is nonatomic would BE trigger be atomic or nonatomic? > So the question is: is there any issue with sending an IPC in a DAI > trigger callback? Sorry looks like we diverged, orignal question was can we do heavy tasks in trigger, the answer is no, unless one uses nonatomic flag which was added so that people can do that work with DSPs like sending IPCs.. Maybe we should add heavy slimbus/soundwire handling to it too...? > This is not very different from sending a command on a > bus btw, I see a similar example for SLIMbus devices: > > wcd9335.c: case SNDRV_PCM_TRIGGER_SUSPEND: > wcd9335.c- case SNDRV_PCM_TRIGGER_PAUSE_PUSH: > wcd9335.c- slim_stream_unprepare(dai_data->sruntime); > wcd9335.c- slim_stream_disable(dai_data->sruntime); > > int slim_stream_unprepare(struct slim_stream_runtime *stream) > { > int i; > > for (i = 0; i < stream->num_ports; i++) > slim_disconnect_port(stream, &stream->ports[i]); > > static int slim_disconnect_port(struct slim_stream_runtime *stream, > struct slim_port *port) > { > struct slim_device *sdev = stream->dev; > u8 wbuf[1]; > struct slim_val_inf msg = {0, 1, NULL, wbuf, NULL}; > u8 mc = SLIM_MSG_MC_DISCONNECT_PORT; > DEFINE_SLIM_LDEST_TXN(txn, mc, 5, stream->dev->laddr, &msg); > > wbuf[0] = port->id; > port->ch.state = SLIM_CH_STATE_DISCONNECTED; > port->state = SLIM_PORT_DISCONNECTED; > > return slim_do_transfer(sdev->ctrl, &txn); > } > > Such commands may take time... Agree, so users should be recommended to use nonatomic triggers. -- ~Vinod