From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC20C4338F for ; Fri, 6 Aug 2021 10:45:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8BC461167 for ; Fri, 6 Aug 2021 10:45:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A8BC461167 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bna0NBTQ5YINafEC19y04ixayEVqWUgmng+uevRHHio=; b=GhjzBMPFNLhd0+ E1AJ+/CEYKKFQ17BmcayBM1J6A/ry+7b7Hj/aqs5KOPzB7kdUXepL93pqxUaBKeJGYMfAm3L6ecvJ S+FJ+svkhM8vrN90zpoNcE941z09gyL4UcTV5GMcDIlDHuMmXv8KH4KYpqMh4kZiLA4BB5ZvmPVZJ 3CvGAdNo2bnCJLjbe/4qJlh2nAslVgn52Fo2d5LZPS+S6NvaPgvaF8X9J2dBE+/F3AvRk9nKo25fJ BLL8DSiYBItiz2MyoCu6RB3/sqhlf/zvyhISXOTXAar+I7MnOiAKucd+tZ9Q4sjbRey6JbK7b02Xu S26OD83N4TGNYOX6CxYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBxKa-00C9lq-NN; Fri, 06 Aug 2021 10:44:00 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBxKW-00C9kh-Pw for linux-arm-kernel@lists.infradead.org; Fri, 06 Aug 2021 10:43:58 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 070B64FB; Fri, 6 Aug 2021 12:43:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628246631; bh=RKzilY57EhrbC4I4R8TbW1muRU/5HGcmZ+6oW6fCDL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O73LL5TtntX68qiwrKwSSvdHEfSCRscRR2OLhZNXzRiTf6TXBcLyDFfZq8LyGvCHa xQWPpLiOR3qodAhCjMObzZ+75SDb4+9hmF06wEgJlEFycFJ/Z+k1AAFRYKHs/SwNRY 6JkXU/Icmv0aMYIA689lpV0Lg+TsB+VKCtSnj7CY= Date: Fri, 6 Aug 2021 13:43:37 +0300 From: Laurent Pinchart To: Michal Simek Cc: Quanyang Wang , Hyun Kwon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm , LKML Subject: Re: [V2][PATCH] drm: xlnx: zynqmp: release reset to DP controller before accessing DP registers Message-ID: References: <20210323025501.1568039-1-quanyang.wang@windriver.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210806_034357_036180_EF6EF9CE X-CRM114-Status: GOOD ( 20.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWljaGFsZSwKCk9uIEZyaSwgQXVnIDA2LCAyMDIxIGF0IDEyOjM3OjA3UE0gKzAyMDAsIE1p Y2hhbCBTaW1layB3cm90ZToKPiBzdCAyNC4gMy4gMjAyMSB2IDQ6MTUgb2Rlc8OtbGF0ZWwgTGF1 cmVudCBQaW5jaGFydCBuYXBzYWw6Cj4gPiBPbiBUdWUsIE1hciAyMywgMjAyMSBhdCAxMDo1NTow MUFNICswODAwLCBxdWFueWFuZy53YW5nQHdpbmRyaXZlci5jb20gd3JvdGU6Cj4gPiA+IEZyb206 IFF1YW55YW5nIFdhbmcgPHF1YW55YW5nLndhbmdAd2luZHJpdmVyLmNvbT4KPiA+ID4KPiA+ID4g V2hlbiBpbnNtb2QgenlucW1wLWRwc3ViLmtvIGFmdGVyIHJtbW9kIGl0LCBzeXN0ZW0gd2lsbCBo YW5nIHdpdGggdGhlCj4gPiA+IGVycm9yIGxvZyBhcyBiZWxvdzoKPiA+ID4KPiA+ID4gcm9vdEB4 aWxpbngtenlucW1wOn4jIGluc21vZCB6eW5xbXAtZHBzdWIua28KPiA+ID4gWyAgIDg4LjM5MTI4 OV0gW2RybV0gSW5pdGlhbGl6ZWQgenlucW1wLWRwc3ViIDEuMC4wIDIwMTMwNTA5IGZvciBmZDRh MDAwMC5kaXNwbGF5IG9uIG1pbm9yIDAKPiA+ID4gWyAgIDg4LjUyOTkwNl0gQ29uc29sZTogc3dp dGNoaW5nIHRvIGNvbG91ciBmcmFtZSBidWZmZXIgZGV2aWNlIDEyOHg0OAo+ID4gPiBbICAgODgu NTQ5NDAyXSB6eW5xbXAtZHBzdWIgZmQ0YTAwMDAuZGlzcGxheTogW2RybV0gZmIwOiB6eW5xbXAt ZHBzdWJkcm0gZnJhbWUgYnVmZmVyIGRldmljZQo+ID4gPiBbICAgODguNTcxNjI0XSB6eW5xbXAt ZHBzdWIgZmQ0YTAwMDAuZGlzcGxheTogWnlucU1QIERpc3BsYXlQb3J0IFN1YnN5c3RlbSBkcml2 ZXIgcHJvYmVkCj4gPiA+IHJvb3RAeGlsaW54LXp5bnFtcDp+IyBybW1vZCB6eW5xbXBfZHBzdWIK PiA+ID4gWyAgIDk0LjAyMzQwNF0gQ29uc29sZTogc3dpdGNoaW5nIHRvIGNvbG91ciBkdW1teSBk ZXZpY2UgODB4MjUKPiA+ID4gcm9vdEB4aWxpbngtenlucW1wOn4jIGluc21vZCB6eW5xbXAtZHBz dWIua28KPiA+ID4gICAgICAgPGhhbmcgaGVyZT4KPiA+ID4KPiA+ID4gVGhpcyBpcyBiZWNhdXNl IHRoYXQgaW4genlucW1wX2RwX3Byb2JlIGl0IHRyaWVzIHRvIGFjY2VzcyBzb21lIERQCj4gPiA+ IHJlZ2lzdGVycyB3aGlsZSB0aGUgRFAgY29udHJvbGxlciBpcyBzdGlsbCBpbiB0aGUgcmVzZXQg c3RhdGUuIFdoZW4KPiA+ID4gcnVubmluZyAicm1tb2QgenlucW1wX2Rwc3ViIiwgenlucW1wX2Rw X3Jlc2V0KGRwLCB0cnVlKSBpbgo+ID4gPiB6eW5xbXBfZHBfcGh5X2V4aXQgaXMgY2FsbGVkIHRv IGZvcmNlIHRoZSBEUCBjb250cm9sbGVyIGludG8gdGhlIHJlc2V0Cj4gPiA+IHN0YXRlLiBUaGVu IGluc21vZCB3aWxsIGNhbGwgenlucW1wX2RwX3Byb2JlIHRvIHByb2dyYW0gdGhlIERQIHJlZ2lz dGVycywKPiA+ID4gYnV0IGF0IHRoaXMgbW9tZW50IHRoZSBEUCBjb250cm9sbGVyIGhhc24ndCBi ZWVuIGJyb3VnaHQgb3V0IG9mIHRoZSByZXNldAo+ID4gPiBzdGF0ZSB5ZXQgc2luY2UgdGhlIGZ1 bmN0aW9uIHp5bnFtcF9kcF9yZXNldChkcCwgZmFsc2UpIGlzIGNhbGxlZCBsYXRlciBhbmQKPiA+ ID4gdGhpcyB3aWxsIHJlc3VsdCB0aGUgc3lzdGVtIGhhbmcuCj4gPiA+Cj4gPiA+IFJlbGVhc2lu ZyB0aGUgcmVzZXQgdG8gRFAgY29udHJvbGxlciBiZWZvcmUgYW55IHJlYWQvd3JpdGUgb3BlcmF0 aW9uIHRvIGl0Cj4gPiA+IHdpbGwgZml4IHRoaXMgaXNzdWUuIEFuZCBmb3Igc3ltbWV0cnksIG1v dmUgenlucW1wX2RwX3Jlc2V0KCkgY2FsbCBmcm9tCj4gPiA+IHp5bnFtcF9kcF9waHlfZXhpdCgp IHRvIHp5bnFtcF9kcF9yZW1vdmUoKS4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogUXVhbnlh bmcgV2FuZyA8cXVhbnlhbmcud2FuZ0B3aW5kcml2ZXIuY29tPgo+ID4KPiA+IFJldmlld2VkLWJ5 OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4g Cj4gQ2FuIHNvbWVvbmUgcGljayB0aGlzIHBhdGNoPwoKSSBoYXZlIGl0IGluIG15IHRyZWUgd2l0 aCBhIHNldCBvZiBvdGhlciBjaGFuZ2VzLCBJIGludGVuZCB0byBzZW5kIGEKcHVsbCByZXF1ZXN0 IHRvZGF5LgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE82C4338F for ; Fri, 6 Aug 2021 10:43:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED1E561154 for ; Fri, 6 Aug 2021 10:43:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED1E561154 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A08246E828; Fri, 6 Aug 2021 10:43:54 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3077F6E828 for ; Fri, 6 Aug 2021 10:43:53 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 070B64FB; Fri, 6 Aug 2021 12:43:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628246631; bh=RKzilY57EhrbC4I4R8TbW1muRU/5HGcmZ+6oW6fCDL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O73LL5TtntX68qiwrKwSSvdHEfSCRscRR2OLhZNXzRiTf6TXBcLyDFfZq8LyGvCHa xQWPpLiOR3qodAhCjMObzZ+75SDb4+9hmF06wEgJlEFycFJ/Z+k1AAFRYKHs/SwNRY 6JkXU/Icmv0aMYIA689lpV0Lg+TsB+VKCtSnj7CY= Date: Fri, 6 Aug 2021 13:43:37 +0300 From: Laurent Pinchart To: Michal Simek Cc: Quanyang Wang , Hyun Kwon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm , LKML Subject: Re: [V2][PATCH] drm: xlnx: zynqmp: release reset to DP controller before accessing DP registers Message-ID: References: <20210323025501.1568039-1-quanyang.wang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Michale, On Fri, Aug 06, 2021 at 12:37:07PM +0200, Michal Simek wrote: > st 24. 3. 2021 v 4:15 odesílatel Laurent Pinchart napsal: > > On Tue, Mar 23, 2021 at 10:55:01AM +0800, quanyang.wang@windriver.com wrote: > > > From: Quanyang Wang > > > > > > When insmod zynqmp-dpsub.ko after rmmod it, system will hang with the > > > error log as below: > > > > > > root@xilinx-zynqmp:~# insmod zynqmp-dpsub.ko > > > [ 88.391289] [drm] Initialized zynqmp-dpsub 1.0.0 20130509 for fd4a0000.display on minor 0 > > > [ 88.529906] Console: switching to colour frame buffer device 128x48 > > > [ 88.549402] zynqmp-dpsub fd4a0000.display: [drm] fb0: zynqmp-dpsubdrm frame buffer device > > > [ 88.571624] zynqmp-dpsub fd4a0000.display: ZynqMP DisplayPort Subsystem driver probed > > > root@xilinx-zynqmp:~# rmmod zynqmp_dpsub > > > [ 94.023404] Console: switching to colour dummy device 80x25 > > > root@xilinx-zynqmp:~# insmod zynqmp-dpsub.ko > > > > > > > > > This is because that in zynqmp_dp_probe it tries to access some DP > > > registers while the DP controller is still in the reset state. When > > > running "rmmod zynqmp_dpsub", zynqmp_dp_reset(dp, true) in > > > zynqmp_dp_phy_exit is called to force the DP controller into the reset > > > state. Then insmod will call zynqmp_dp_probe to program the DP registers, > > > but at this moment the DP controller hasn't been brought out of the reset > > > state yet since the function zynqmp_dp_reset(dp, false) is called later and > > > this will result the system hang. > > > > > > Releasing the reset to DP controller before any read/write operation to it > > > will fix this issue. And for symmetry, move zynqmp_dp_reset() call from > > > zynqmp_dp_phy_exit() to zynqmp_dp_remove(). > > > > > > Signed-off-by: Quanyang Wang > > > > Reviewed-by: Laurent Pinchart > > Can someone pick this patch? I have it in my tree with a set of other changes, I intend to send a pull request today. -- Regards, Laurent Pinchart