From: Lee Jones <lee.jones@linaro.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alistair23@gmail.com
Subject: Re: [PATCH v9 03/12] mfd: simple-mfd-i2c: Save the register client data
Date: Fri, 6 Aug 2021 12:38:36 +0100 [thread overview]
Message-ID: <YQ0fPEeZGYe7f1cC@google.com> (raw)
In-Reply-To: <20210806091058.141-4-alistair@alistair23.me>
On Fri, 06 Aug 2021, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> drivers/mfd/simple-mfd-i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> index 583e8c7924af..633a2b28b6cb 100644
> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -48,6 +48,8 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c)
> if (IS_ERR(regmap))
> return PTR_ERR(regmap);
>
> + i2c_set_clientdata(i2c, regmap);
> +
No need to store this here.
Just do this in the child device:
dev_get_regmap(pdev->dev.parent, NULL);
> /* If no MFD cells are spedified, use register the DT child nodes instead */
> if (!simple_mfd_data || !simple_mfd_data->mfd_cell)
> return devm_of_platform_populate(&i2c->dev);
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-08-06 11:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 9:10 [PATCH v9 00/12] Add support for the silergy,sy7636a Alistair Francis
2021-08-06 9:10 ` [PATCH v9 01/12] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis
2021-08-06 9:10 ` [PATCH v9 02/12] mfd: simple-mfd-i2c: Add a Kconfig name Alistair Francis
2021-08-06 11:39 ` Lee Jones
2021-08-06 11:47 ` Alistair Francis
2021-08-06 9:10 ` [PATCH v9 03/12] mfd: simple-mfd-i2c: Save the register client data Alistair Francis
2021-08-06 11:38 ` Lee Jones [this message]
2021-08-06 11:45 ` Mark Brown
2021-08-09 11:14 ` Lee Jones
2021-08-10 7:03 ` Alistair Francis
2021-08-06 9:10 ` [PATCH v9 04/12] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Alistair Francis
2021-08-06 11:39 ` Lee Jones
2021-08-06 9:10 ` [PATCH v9 05/12] regulator: sy7636a: Use the regmap directly Alistair Francis
2021-08-06 9:10 ` [PATCH v9 06/12] regulator: sy7636a: Remove requirement on sy7636a mfd Alistair Francis
2021-08-06 9:10 ` [PATCH v9 07/12] thermal: sy7636a: Add thermal driver for sy7636a Alistair Francis
2021-08-06 9:10 ` [PATCH v9 08/12] hwmon: sy7636a: Add temperature " Alistair Francis
2021-08-06 9:10 ` [PATCH v9 09/12] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis
2021-08-06 9:10 ` [PATCH v9 10/12] ARM: dts: imx7d: remarkable2: " Alistair Francis
2021-08-06 9:10 ` [PATCH v9 11/12] ARM: imx_v6_v7_defconfig: Enable backlight class devices Alistair Francis
2021-08-06 9:10 ` [PATCH v9 12/12] ARM: dts: imx7d: remarkable2: Enable lcdif Alistair Francis
2021-08-09 13:06 ` (subset) [PATCH v9 00/12] Add support for the silergy,sy7636a Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ0fPEeZGYe7f1cC@google.com \
--to=lee.jones@linaro.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.